From owner-freebsd-current@freebsd.org Mon May 9 18:45:47 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E91EB34132; Mon, 9 May 2016 18:45:47 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (mx.catwhisker.org [198.144.209.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 281EF1E8B; Mon, 9 May 2016 18:45:46 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.15.2/8.15.2) with ESMTP id u49Ijip2020173; Mon, 9 May 2016 18:45:44 GMT (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.15.2/8.15.2/Submit) id u49Ijiq9020172; Mon, 9 May 2016 11:45:44 -0700 (PDT) (envelope-from david) Date: Mon, 9 May 2016 11:45:44 -0700 From: David Wolfskill To: John Baldwin Cc: freebsd-current@freebsd.org, "freebsd-pkgbase@freebsd.org" Subject: Re: NO_INSTALLEXTRAKERNELS and PkgBase Message-ID: <20160509184544.GU1063@albert.catwhisker.org> Reply-To: freebsd-current@freebsd.org, "freebsd-pkgbase@freebsd.org" Mail-Followup-To: freebsd-current@freebsd.org, "freebsd-pkgbase@freebsd.org" , John Baldwin References: <20160507135005.GN62286@albert.catwhisker.org> <3382220.3AgOZzUBmF@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HC0F8i/BfMshQzR8" Content-Disposition: inline In-Reply-To: <3382220.3AgOZzUBmF@ralph.baldwin.cx> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 18:45:47 -0000 --HC0F8i/BfMshQzR8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 09, 2016 at 11:05:55AM -0700, John Baldwin wrote: > On Saturday, May 07, 2016 06:50:05 AM David Wolfskill wrote: > > [Recipient list trimmed a bit -- dhw] > ...=20 > > > 2 kernels get installed? Even if the old behaviour was to only instal= l 1 > > > kernel, if you are listing 2 kernels in KERNCONF presumably that is b= ecause > > > you want to install 2 kernels? > >=20 > > Errr... no: I don't. At least, not on the machine where I built them. >=20 > Then don't pass them to 'installkernel'? That is, I think this makes sen= se > if you want to build N kernels but only install 1: >=20 > make buildkernel KERNCONF=3D"FOO BAR BAZ" >=20 > # only install the FOO kernel >=20 > make installkernel KERNCONF=3D"FOO" >=20 > And then if you want to install multiple: >=20 > # install both FOO and BAR kernels >=20 > make installkernel KERNCONF=3D"FOO BAR" I suppose there's probably some way to arrange things so the KERNCONF specification in /etc/src.conf has one value during "buildkernel" and a different value during "inistallkernel" -- but ... seriously...??!? Wouldn't it be cleaner to have different variables (e.g., that could each default to the KERNCONF specification, but could be overridden in a simple text file that doesn't require delving into make(1) arcana to craft or understand)? Why make things harder for folks who are trying to use the system? > The runaround seems to be whether this last case now should require multi= ple > explicit installkernel invocations which I find inconsistent since the bu= ild > stage doesn't. I would fully expect 'installkernel' to install all of the > kernels listed in KERNCONF and would assume that it is up to the invoker = to > choose KERNCONF appropriately. > .... Multiple installkernel invocations is certainly not something I would advocate -- I do silly things sometimes, but I hope nothing I wrote was interpreted thus. :-} Suppose that src/Makefile.inc1 were modified so that: * KERNCONF_BUILD is set to the value (explicit or otherwise) of KERNCONF unless it already has a value (in which case, the explicit value is used). * KERNCONF_INSTALL is set to the value (explicit or otherwise) of KERNCONF unless it already has a value (in which case, the explicit value is used). buildkernel then builds the kernel configs listed in KERNCONF_BUILD; installkernel then installs the kernels listed in KERNCONF_INSTALL. Folks who want to build & install the same set of kernels see no change. Folks who want a difference between "buildkernel" and "installkernel" have a simple way to specify it. Only 1 invocation of installkernel is needed in any case. Would that work? It seems as if that would work for my case. Peace, david --=20 David H. Wolfskill david@catwhisker.org Those who would murder in the name of God or prophet are blasphemous coward= s. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --HC0F8i/BfMshQzR8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJXMNrYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDQ0I3Q0VGOTE3QTgwMUY0MzA2NEQ3N0Ix NTM5Q0M0MEEwNDlFRTE3AAoJEBU5zECgSe4XovMH/RgLIQb3OHBChCDDfb8FnV3v VP7E9MMLLLT7JvaSp0HVRyFzQPaCGqZwJi0e1g/UvfcEbUZKtBdRvhGE3FeMP5Ck yzTe5KBtHon9azxnjVjEk0+83d18zNdECxu+mZA4+xT8jKf9n0S7hle2lTGuDpHa q/s8Yn6Iso3pD87Fic4fCBaXHpgreo215lfccri6EbFgrYy0gLUCUA9z/W2gudEi TCzigy3uej6Bt76xPzyLvnGb8Ev4oFcecEkEwVTYQvneOLCNbjbam0UykI+KaHSU 9AJUwSt7giuL44lWtX9pNFL/wfoLWRWcMqYvDmAPmcd+KYxuiQm0cxdY7xAsJ9k= =hnbh -----END PGP SIGNATURE----- --HC0F8i/BfMshQzR8--