From nobody Mon Mar 31 19:14:38 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRLRc5dk9z5sRLk for ; Mon, 31 Mar 2025 19:14:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRLRc0RJ7z3MCs for ; Mon, 31 Mar 2025 19:14:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso46072525e9.1 for ; Mon, 31 Mar 2025 12:14:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743448490; x=1744053290; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpizo2OwMi+XLl0pQ13vqszssQcb/KqimIYqrBm2c4s=; b=Vce4F7WeT0NfcZB+ouNBshb8YfjN4bsv01d/loyESWmVWhfmJ6EoyVgrUt0EWevRFx H+JpotcREa6JCONfU6WMXxMF4nhd3Rl0n6avBe/Kkpss9Wzt8TAjsI131+4DOr0WdQUp qlIZ7RX5hLzfzvVaYnFFx0AkrdjS0bwwWbkDiBmP2N7f4r9qTMrwoY0eZOPxD/vFGsfV pMEirSrI7hInhbGlgcMGo8QDi6EJarFqJHeT0w5Md/dQi10lhjX1I6TSVMgAjMHQsshI lOKfhfIp6Cauht7V5X89UeZKetyg213i0HQCsSgQxPabHHuGrDbvhNgoh5xm8OQTN++E /lbQ== X-Forwarded-Encrypted: i=1; AJvYcCWmLYPSYkklX9ByKinvjc+t0D9fSXudmmtdbB5csc4lZmkmbHmoRHhUgzagB/OYusJVxiIjs2DH90ZFinowvbJXkgNS@freebsd.org X-Gm-Message-State: AOJu0YxsT0jknbJcahukc/qcnwuloJdpT5UrvaSJRdfZsDzdX0FfVuVF mFpaXjH6+4/4kSA/Rdb2HFOPcX7G7PLSejdUMU/uonTAR03dlTBzzX2K2aTm+W8= X-Gm-Gg: ASbGnctzlG88nIVxlquK7HxGz/IVQQU0rOUEXwRFaokJX6IUW7ZqaunMbrGhvFvHtwE 0DITHdSHL16I2CZKcg3p0xCrjr4TtZAfEpHCTQDagby4Z+PkkpH1t+QYGyISWIQt3UOpCtKYQh6 EnnfQV/oukYSoyEvPyndjAb0MRwY1EaWuuxk77lJOqAj2Mtwvfrp12GVfa4tPyn6KTyaCz2oBDE jiEhyjO2VdU9MwmYFNAmp8AJyTzDJq3Q7SzsxuQZBkpQCqWWfdu11yGJ43qZ3/ERFh4mDyg5txW grb7HygA+CQMZQwWg12oLx7FAUJcznBWQ79d4Y6mBJyx3dSTEwiB2D+0PnY9YQin5H/uUw== X-Google-Smtp-Source: AGHT+IHOhkc2kYVm9Wjh0IIAq3Zv6g7qTx5Huz6nefadVxaHauRYfLGWOMGTRsRC+0cJPzqyaqKYig== X-Received: by 2002:a05:600c:34c1:b0:43d:b85:1831 with SMTP id 5b1f17b1804b1-43dabe240cemr111495185e9.0.1743448490375; Mon, 31 Mar 2025 12:14:50 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82e6a532sm172788125e9.9.2025.03.31.12.14.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Mar 2025 12:14:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: 0e33c2e6df7a - main - pci: Only re-route IRQs based on firmware on x86 From: Jessica Clarke In-Reply-To: <202503292018.52TKI7va048377@gitrepo.freebsd.org> Date: Mon, 31 Mar 2025 20:14:38 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202503292018.52TKI7va048377@gitrepo.freebsd.org> To: Colin Percival X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Spamd-Result: default: False [2.76 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_SPAM_MEDIUM(0.91)[0.911]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; NEURAL_SPAM_SHORT(0.24)[0.245]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[jrtc27]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.43:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; RBL_SENDERSCORE_REPUT_8(0.00)[209.85.128.43:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.43:from]; FROM_HAS_DN(0.00)[] X-Rspamd-Queue-Id: 4ZRLRc0RJ7z3MCs X-Spamd-Bar: ++ On 29 Mar 2025, at 20:18, Colin Percival wrote: >=20 > The branch main has been updated by cperciva: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D0e33c2e6df7a5de65db40c7cc0fc97f6= 6da28ccd >=20 > commit 0e33c2e6df7a5de65db40c7cc0fc97f66da28ccd > Author: Colin Percival > AuthorDate: 2025-03-28 18:07:01 +0000 > Commit: Colin Percival > CommitDate: 2025-03-29 20:17:29 +0000 >=20 > pci: Only re-route IRQs based on firmware on x86 >=20 > There is a (very historical) call to pci_assign_interrupt for the > purpose of routing IRQs which may have been set up wrong by x86 = BIOS > or firmware. On non-x86 systems, this is unnecessary; and on = INTRNG > systems it results in a (synthetic) IRQ leak and ultimately a = kernel > panic after many hotplug/unplug cycles. This is in fact incorrect. Whilst there may well be a leak that needs fixing, the rerouting is absolutely needed on non-x86 platforms. See 5884fab46153dee52bda660bcabca95c3cc97f44 and 7de649170fd804668da78f005c7966941b402106 for some of the history behind this. As a result of this commit the problem described in the second commit is reintroduced. Jess > Suggested by: jhb > Reviewed by: jhb > MFC after: 2 weeks > Sponsored by: Amazon > Differential Revision: https://reviews.freebsd.org/D49560 > --- > sys/dev/pci/pci.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c > index fe99d6beb029..3a51e4c38296 100644 > --- a/sys/dev/pci/pci.c > +++ b/sys/dev/pci/pci.c > @@ -4175,6 +4175,7 @@ pci_add_resources(device_t bus, device_t dev, = int force, uint32_t prefetchmask) > if (q->devid =3D=3D devid && q->type =3D=3D PCI_QUIRK_MAP_REG) > pci_add_map(bus, dev, q->arg1, rl, force, 0); >=20 > +#if defined(__i386__) || defined(__amd64__) > if (cfg->intpin > 0 && PCI_INTERRUPT_VALID(cfg->intline)) { > /* > * Try to re-route interrupts. Sometimes the BIOS or > @@ -4184,6 +4185,7 @@ pci_add_resources(device_t bus, device_t dev, = int force, uint32_t prefetchmask) > */ > pci_assign_interrupt(bus, dev, 1); > } > +#endif >=20 > if (pci_usb_takeover && pci_get_class(dev) =3D=3D PCIC_SERIALBUS && > pci_get_subclass(dev) =3D=3D PCIS_SERIALBUS_USB) {