From owner-svn-src-head@freebsd.org Tue Apr 25 22:12:46 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E3A9D33713; Tue, 25 Apr 2017 22:12:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 05E8B304; Tue, 25 Apr 2017 22:12:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-it0-x230.google.com with SMTP id g66so28494246ite.1; Tue, 25 Apr 2017 15:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qLo9Hc99PFgFBx3FDjloRysWQPFo8/P6DEVlB+RPVqs=; b=jXxfABgq4YKu2zwz+Lr6XQgawlxEy8GYt8j4L+dv6zxmmlrUJfnhuiLTOO3umAd/mY AXTZfTVEqPGSxS934JFJ00YAXvDClnCqBkH1IKhFckYNyTq5v3utbK0tYKG1g95C5q/U tVSmrPz/jlaCQtg5SlJaBXlCXOO8vPYOQcHnqPTsjS6Ppy8FO4FF9ORouyrkNFjnSX+j /YtL1SoajXHINRyUmUGSvSQz4pZ23eK56h2WQP2O6QiQOjsJuAF1/g+JwLftwQB8hmE4 VjUtY+n96O01Rl+qrAJBdxUm2zC5B+Qhxje0AYsmv+tqpeoMnwyIiqXPlkUJ9XoNaFJX hLpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qLo9Hc99PFgFBx3FDjloRysWQPFo8/P6DEVlB+RPVqs=; b=IMKl2y0aZEt7HEwmqAYEAolXrjd/vjcQJi2BSLYKSsMToJAf3HDVoxRAoMZgN+i9Zw pNhZ7kkwj7VlC3m8u7KxtTHTX0/NLVlcVloghVpNeSBQNX8y+ZSk8ak1UqwNntpUiKbF lP2fKLgxI/8xhvrzKwKhRLtVHI4crdlTVEvkPzwIlekBWhbeox8n+L8aEKIP6aAV7yKg RvI4apczqeip0Ij3W0xJPz0OtMq0jOmpqSAovJkGby98N0FfNMshDTWTO2nJUOby3+xt xDgiRtc+FNB4f2SlhbAoeIqH5d9uziGQ/tr9npfMmFe2J8AsaSe/Eo7DcOUzHjGSaG5B jOIQ== X-Gm-Message-State: AN3rC/4AGUV/Yq22wyRyNb7cabtq1/RynkjLSuo22LzK/ykWI1w+jnzJ uazAb+nfJtQFp/aGrCNaClIf7P55uQ== X-Received: by 10.36.101.210 with SMTP id u201mr3445127itb.118.1493158365365; Tue, 25 Apr 2017 15:12:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.164.170 with HTTP; Tue, 25 Apr 2017 15:12:44 -0700 (PDT) In-Reply-To: References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> From: Ngie Cooper Date: Tue, 25 Apr 2017 15:12:44 -0700 Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump To: Bryan Drewery Cc: Benjamin Kaduk , John Baldwin , "Rodney W. Grimes" , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 22:12:46 -0000 On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery wrote: ... > It is definitely more useful to note which repository and what VCS > system the revision/hash/version refers to. But there's nothing > inherently wrong about using a git hash. Github != git. It is merely an > interface to git and is not required to use any of the git repositories > on it given another mirror or local checkout. If a project uses git as > their official VCS then a git hash is the proper reference. The only issues with using git hashes stems from forced pushes and the fact that only hashes can be garbage collected, but if we're using an upstream that does that, they are using git wrong (it should only be done for non-development mainlines). Then again, at least the history will have been somewhat correct, as cvs/svn history can be rewritten :/... Thanks, -Ngie