From owner-cvs-all Mon May 28 6: 3:53 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 3E54F37B423; Mon, 28 May 2001 06:03:46 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA27466; Mon, 28 May 2001 23:03:43 +1000 Date: Mon, 28 May 2001 23:02:11 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: n_hibma@FreeBSD.org Cc: Poul-Henning Kamp , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_disk.c In-Reply-To: <20010528125004.C93973-100000@henny.webweaving.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 28 May 2001 n_hibma@FreeBSD.org wrote: > Reverting this commit avoids the panic I just mailed you. No idea why. > > Anything you want me to try to look into this? Little problem is that I > don't have a serial console and the panic happens before dumpdev is set. This may be related to rev.1.38 of subr_disk.c breaking most disk devices in the non-devfs case. Their devsw() is 0 so spec_open() returns ENXIO. Places that don't check for a null devsw() would just panic. I think Bruce > On Thu, 24 May 2001, Poul-Henning Kamp wrote: > > > phk 2001/05/24 13:27:17 PDT > > > > Modified files: > > sys/kern subr_disk.c > > Log: > > Don't take the detour around devsw() to find out if the proto-cdevsw > > is already initialized. > > > > Revision Changes Path > > 1.38 +2 -4 src/sys/kern/subr_disk.c > > > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/subr_disk.c?r1=1.37&r2=1.38&cvsroot=freebsd To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message