From owner-p4-projects@FreeBSD.ORG  Wed Oct 29 18:14:49 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E065F16A4D0; Wed, 29 Oct 2003 18:14:48 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B8CA416A4CE
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 18:14:48 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4218743FBD
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 18:14:48 -0800 (PST)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h9U2EmXJ079551
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 18:14:48 -0800 (PST)
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h9U2El6c079548
	for perforce@freebsd.org; Wed, 29 Oct 2003 18:14:47 -0800 (PST)
	(envelope-from sam@freebsd.org)
Date: Wed, 29 Oct 2003 18:14:47 -0800 (PST)
Message-Id: <200310300214.h9U2El6c079548@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 40795 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Oct 2003 02:14:49 -0000

http://perforce.freebsd.org/chv.cgi?CH=40795

Change 40795 by sam@sam_ebb on 2003/10/29 18:14:45

	grab the tree lock before calling rtexpunge to avoid a LOR
	seen when ejecting a removable NIC

Affected files ...

.. //depot/projects/netperf/sys/netinet6/in6_ifattach.c#11 edit

Differences ...

==== //depot/projects/netperf/sys/netinet6/in6_ifattach.c#11 (text+ko) ====

@@ -904,12 +904,15 @@
 	sin6.sin6_family = AF_INET6;
 	sin6.sin6_addr = in6addr_linklocal_allnodes;
 	sin6.sin6_addr.s6_addr16[1] = htons(ifp->if_index);
+	/* XXX grab lock first to avoid LOR */
+	RADIX_NODE_HEAD_LOCK(rt_tables[AF_INET6]);
 	rt = rtalloc1((struct sockaddr *)&sin6, 0, 0UL);
 	if (rt) {
 		if (rt->rt_ifp == ifp)
 			rtexpunge(rt);
 		RTFREE_LOCKED(rt);
 	}
+	RADIX_NODE_HEAD_UNLOCK(rt_tables[AF_INET6]);
 }
 
 void