From owner-cvs-all Thu Jan 29 06:26:32 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA14570 for cvs-all-outgoing; Thu, 29 Jan 1998 06:26:32 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from word.smith.net.au (ppp4.portal.net.au [202.12.71.104]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA14499; Thu, 29 Jan 1998 06:26:03 -0800 (PST) (envelope-from mike@word.smith.net.au) Received: from word (localhost [127.0.0.1]) by word.smith.net.au (8.8.8/8.8.5) with ESMTP id AAA00577; Fri, 30 Jan 1998 00:48:51 +1030 (CST) Message-Id: <199801291418.AAA00577@word.smith.net.au> X-Mailer: exmh version 2.0zeta 7/24/97 To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa wfd.c In-reply-to: Your message of "Thu, 29 Jan 1998 21:09:39 +1100." <199801291009.VAA22501@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 30 Jan 1998 00:48:50 +1030 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe cvs-all" > >> >It was not clear that this was legitimate; I infer from this that the > >> >correct approach is to return a nonzero value in b_resid, which will > >> >cause another call to the strategy routine. Is that correct? Will > >> >this work on 2.2? It's certainly a *much* tidier approach than what I > >> >am currently doing. > >> > >> Only for raw i/o. bread() and bwrite() don't even look at b_resid. > > > >Then it strikes me that you're suggesting a non-solution. Any other > >ideas? > > It's good enough for SCSI drivers. You just previously said that it wasn't adequate. Please make up your mind. 8) Either I should: - Leave things as they are (possibly suboptimal, but apparently functional). - Change to only handling as much of the request as we can in a single pass and leaving the overs in b_resid. So far you have suggested that I should do the second, because that's what SCSI adapters do, even though they never do because they can all handle MAXPHYS-sized transfers, and not all the calling code will honour the returned value in b_resid. This doesn't sound like much of a recommendation to me. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\