Date: Tue, 19 May 2015 16:37:51 +0000 From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2579: PCI support for Alpine platform from Annapurna Labs Message-ID: <8aba59ef998647039c1186c83c825f5a@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org> References: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
emaste added inline comments. INLINE COMMENTS sys/arm/annapurna/alpine/alpine_pci.c:414 See e.g. this discussion from LLVM's coding standards doc: http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code We don't have this explicitly documented in FreeBSD, but in general prefer early returns. REVISION DETAIL https://reviews.freebsd.org/D2579 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: jpa-semihalf.com, ian, imp, andrew, jhb, onwahe-gmail-com, meloun-miracle-cz, br, sson, loos, sbruno, rpaulo Cc: emaste, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8aba59ef998647039c1186c83c825f5a>