Date: Sun, 9 Sep 2012 15:07:44 GMT From: Olli Hauer <ohauer@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: bapt@FreeBSD.org Subject: ports/171509: Message-ID: <201209091507.q89F7iWU020958@freefall.freebsd.org> Resent-Message-ID: <201209091510.q89FACBV063267@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 171509
>Category: ports
>Synopsis:
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 09 15:10:11 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Olli Hauer
>Release:
>Organization:
[patch] Mk/bsd.options.mk please wrap the backward compatibility between an additional check
>Environment:
>Description:
Please can we add the patch below to bsd.options.mk.
This will allow to detect WITH... command param and make.conf usage
in the apache ports so we can give the user a hint start reading about
options NG.
Until now many users have build the apache ports with parameters
WITH... and WITHOUT... which do no longer work if options NG is
full implemented in a port.
I suspect the we will see many more requests about the
WITH/WITHOUT usage in next time and without this hack it is not
possible to see if a command line parameter was used or it comes
from the framework.
The following addition to bsd.apache.mk allows us then to give the
user a hint if we add the following snippet to the apache files.
Index: www/apache22/Makefile
===================================================================
@@ -23,6 +23,7 @@
apache-2.0.* apache-*-2.0.* \
apache-*-2.2.* apache22-*-2.2.*
+OPTNGONLY= yes
USE_APACHE= common22
USE_BZIP2= yes
USE_ICONV= yes
Index: Mk/bsd.apache.mk
===================================================================
@@ -138,6 +138,12 @@
detected (make.conf), they shoud be UPPERCASE
.endif
+.for module in ${AVAILABLE_MODULES}
+. if defined(WITH_${module})
+BROKEN= Please use the new options NG parameters, start by reading http://wiki.freebsd.org/Ports/Options/OptionsNG
+. endif
+.endfor
>How-To-Repeat:
>Fix:
--- bsd.options.mk.diff begins here ---
Index: /usr/ports/Mk/bsd.options.mk
===================================================================
--- /usr/ports/Mk/bsd.options.mk (revision 303967)
+++ /usr/ports/Mk/bsd.options.mk (working copy)
@@ -224,6 +224,7 @@
.undef _SORTED_OPTIONS
.endif
+.if !defined(OPTNGONLY)
### to be removed once old OPTIONS disappear
.for opt in ${ALL_OPTIONS}
.if empty(PORT_OPTIONS:M${opt})
@@ -238,3 +239,4 @@
. undef opt
.endfor
###
+.endif
--- bsd.options.mk.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209091507.q89F7iWU020958>