From owner-dev-commits-src-all@freebsd.org Mon Jan 25 23:09:26 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1D7B74F6001; Mon, 25 Jan 2021 23:09:26 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DPltY4bw0z3pPp; Mon, 25 Jan 2021 23:09:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id 4Az3lLa552SWT4Az5ll9bF; Mon, 25 Jan 2021 16:09:24 -0700 X-Authority-Analysis: v=2.4 cv=fdJod2cF c=1 sm=1 tr=0 ts=600f4fa4 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=EmqxpYm9HcoA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=EpL3m9P00jwEYAFR2YEA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id AA2901995; Mon, 25 Jan 2021 15:09:19 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 10PN9JcL022164; Mon, 25 Jan 2021 15:09:19 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202101252309.10PN9JcL022164@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jessica Clarke cc: Cy Schubert , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. In-reply-to: References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> Comments: In-reply-to Jessica Clarke message dated "Mon, 25 Jan 2021 22:49:16 +0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 25 Jan 2021 15:09:19 -0800 X-CMAE-Envelope: MS4xfIRFn5XYsgBYsc1dA+XipIA8BKi+rJ5tgaBxhk9Lsw9UrFMyu8lnKUD6I2VJDrK+wsaEtRAA8uC68lUj/w6vwBT3dijkKtjkdBpmnWlZaz9mqYpkSsMg A3JYHp3V78pnaPiXXsVq8wp3LeyC0ksIKED3xEpHOYFn+Crqnl8bCXL7Ew/YkJeTH3lYVz8N+NADyR8lu18dO2lpMnKiiGs6Qo9KrczHbqr6Xf35qOeUnqZR WDW7LChrCXDXTQVWQ4NZ6ZHS2koNtbe+S4OyRG8Hd90/s6lGRSuavSW+JDwotELOkUvCPf5JVcyai0fZuhV2tPyvGgdxvo2Zi9adHbf7hUVBDqVyjYJnIikY 0gnC3+oO X-Rspamd-Queue-Id: 4DPltY4bw0z3pPp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 23:09:26 -0000 In message , Jessica Clarke w rites: > Hi, > > On 25 Jan 2021, at 22:47, Cy Schubert wrote: > > > > diff --git a/contrib/ipfilter/ipf.h b/contrib/ipfilter/ipf.h > > index 05dcfa4afd64..834ba83f51f0 100644 > > --- a/contrib/ipfilter/ipf.h > > +++ b/contrib/ipfilter/ipf.h > > @@ -73,15 +73,7 @@ > > #include "opts.h" > > > > #ifndef __P > > -# ifdef __STDC__ > > # define __P(x) x > > There are a few cases like this where the indentation should be reduced > (or just removed if it's no longer so confusing). There are a number of those in ipfilter, currently. Rather than confuse the functional changes with aesthetic changes, which makes it difficult for people to bisect history, I'll push those prior to the next batch of functional changes. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.