From owner-svn-src-all@FreeBSD.ORG  Wed Jul 17 08:44:34 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 2796B945;
 Wed, 17 Jul 2013 08:44:34 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id CC3DCD5A;
 Wed, 17 Jul 2013 08:44:32 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA28779;
 Wed, 17 Jul 2013 11:44:30 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1UzNLa-000PsF-EK; Wed, 17 Jul 2013 11:44:30 +0300
Message-ID: <51E65936.5070200@FreeBSD.org>
Date: Wed, 17 Jul 2013 11:43:34 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130708 Thunderbird/17.0.7
MIME-Version: 1.0
To: Andrey Chernov <ache@FreeBSD.org>
Subject: Re: svn commit: r253380 - head/lib/libc/stdlib
References: <201307160726.r6G7QlwE045679@svn.freebsd.org>
 <51E61950.5090206@freebsd.org> <51E62219.1090006@freebsd.org>
 <51E62B37.8080900@freebsd.org> <51E6576C.6010000@FreeBSD.org>
 <51E658BD.9020700@freebsd.org>
In-Reply-To: <51E658BD.9020700@freebsd.org>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2013 08:44:34 -0000

on 17/07/2013 11:41 Andrey Chernov said the following:
> On 17.07.2013 12:35, Andriy Gapon wrote:
>>>>>> -		env = stpcpy(envVars[envNdx].name, name);
>>>>>> +		env = stpncpy(envVars[envNdx].name, name, nameLen);
>>>>>>  		if ((envVars[envNdx].name)[nameLen] != '=')
>>>>>>  			env = stpcpy(env, "=");
>>> Microoptimized:
>>>
>>> env = stpncpy(envVars[envNdx].name, name, nameLen);
>>> *env++ = '=';
>>>
>>
>> In fact, I think that the currently committed code is not functionally broken,
>> just weird.
> 
> No. The bad thing is that current code increments "env" pointer
> unpredictable (depending on junk). And the value of variable is written
> to that "env" pointer later will be off by one sometimes.
> 

Ah, true.

-- 
Andriy Gapon