From owner-freebsd-x11@freebsd.org Wed May 25 04:37:59 2016 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3362BB486A7 for ; Wed, 25 May 2016 04:37:59 +0000 (UTC) (envelope-from mmacy@nextbsd.org) Received: from sender163-mail.zoho.com (sender163-mail.zoho.com [74.201.84.163]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08F3419E7 for ; Wed, 25 May 2016 04:37:58 +0000 (UTC) (envelope-from mmacy@nextbsd.org) Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1464151076196264.2028774224924; Tue, 24 May 2016 21:37:56 -0700 (PDT) Date: Tue, 24 May 2016 21:37:56 -0700 From: Matthew Macy To: "Nils Beyer" Cc: "" Message-ID: <154e6346d2e.10672302e141790.3018205346870992567@nextbsd.org> In-Reply-To: <154e4727f68.d96d4366265964.4046041328395915864@nextbsd.org> References: <1540c0ceea9.126b592b988423.8774357707501817476@nextbsd.org> <15449ec286e.11def424858288.297669375175006270@nextbsd.org> <1549f266cc5.ea588cba219264.3594536435079440635@nextbsd.org> <20160521231734.GM21899@ivaldir.etoilebsd.net> <57436A8E.4020109@gmail.com> <154df5bc8e2.b7d4a800194520.6901257599921444588@nextbsd.org> <5743824C.6050308@gmail.com> <154dfc5f7e9.109281b7a199490.5235064548489806889@nextbsd.org> <1854718.X2I93raCOV@asbach.renzel.net> <154e1d87643.b5b82861225515.4992131373924163574@nextbsd.org> <2036793.4G1HTRBqfD@asbach.renzel.net> <154e4727f68.d96d4366265964.4046041328395915864@nextbsd.org> Subject: Re: Re: Update 2 the state of drm-next-4.6 and next steps MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 04:37:59 -0000 > > But DDB via CTRL+ALT+ESC works. The backtrace of the "kldload" process says > > something like: > > ============================================================================== > > sched_switch > > [sleep stuff] > > vm_wait+0xeb > > uma_small_alloc+0x65 > > intel_detect_pch+0x66 > > [...] > > ============================================================================== > > > > I'm not that familiar with DDB or remote debugging at all. If you tell me the > > needed commands in DDB - especially to write the output to disk somewhere - I > > can provide you better informations. > > > > My current GIT stamp says "1e9ceda(drm-next-4.6)-dirty". "dirty" because I've > > removed WITNESS and other debugging stuff apart from KDB/DDB out off my kernel > > config... > >Removing DEBUG functionality when you're testing new unproven code is not a good idea. INVARIANTS and WITNESS are there for your benefit. Nonetheless, you've identified where the memory leak is happening: > >in i915_drv.c :470 the loop run for ever. I need to fix the code to take the pch that's passed back and re-use that on subsequent calls rather allocating a second time. That just begs the question as to what I need to be iterating over. Nonetheless, if I haven't fixed it by the next update I'll at least have made pch detection failure less disastrous. > > > * In some virtualized environments (e.g. XEN), there is irrelevant > * ISA bridge in the system. To work reliably, we should scan trhough > * all the ISA bridge devices and check for the first match, instead > * of only checking the first one. > */ > while ((pch = pci_get_class(PCI_CLASS_BRIDGE_ISA << 8, pch))) { > if (pch->vendor == PCI_VENDOR_ID_INTEL) { > unsigned short id = pch->device & INTEL_PCH_DEVICE_ID_MASK; > dev_priv->pch_id = id; > >Please file an issue against our repo on github so that I have this in my queue later this week when I have time to work on it. > >-M This change should fix the memory leak you're seeing: https://github.com/freebsd/freebsd-base-graphics/commit/308354eb2196b0adcbd24f4f7ba6a8da14e0d98e Note that the remote has changed: https://github.com/FreeBSDDesktop/freebsd-base-graphics.git I doubt this will magically make Atom support work. But it will allow us to make it to the next problem. -M