From owner-freebsd-ports@FreeBSD.ORG Thu Feb 10 14:34:01 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3AEF106566B for ; Thu, 10 Feb 2011 14:34:01 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9F1628FC08 for ; Thu, 10 Feb 2011 14:34:01 +0000 (UTC) Received: by ywl2 with SMTP id 2so612822ywl.13 for ; Thu, 10 Feb 2011 06:34:00 -0800 (PST) Received: by 10.236.111.43 with SMTP id v31mr38831838yhg.23.1297348440444; Thu, 10 Feb 2011 06:34:00 -0800 (PST) Received: from sunpoet.net (sunpoet.net [220.133.12.240]) by mx.google.com with ESMTPS id g63sm41417yhd.15.2011.02.10.06.33.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Feb 2011 06:33:59 -0800 (PST) Sender: Sunpoet Hsieh Received: by sunpoet.net (Postfix, from userid 1000) id BDCB42AEC4A8; Thu, 10 Feb 2011 22:35:06 +0800 (CST) Date: Thu, 10 Feb 2011 22:35:06 +0800 From: Sunpoet Po-Chuan Hsieh To: arrowdodger <6yearold@gmail.com> Message-ID: <20110210143506.GA66529@bonjour.sunpoet.net> References: <20110209161008.GD87684@bonjour.sunpoet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Organization: The FreeBSD Project User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2011 14:34:02 -0000 On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: > I've updated port. The only thing left - setting dependency on py-gobject= by > USE_GNOME variable. > But if i run pkg_info -f on installed port, i see: >=20 > > Dependency: py26-gobject-2.26.0 > > dependency origin: devel/py-gobject > > > So, maybe this dependency is implicit and i should not care? Obviously USE_GNOME does not support devel/py-gobject now. All you can do is to use BUILD_DEPENDS/RUN_DEPENDS. Your pkg_info result indicates that you've installed gobject, but it means nothing to users of this port. The ports infrastructure generates dependency list according to the Makefile. If py-gobject is required, add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will not be installed. > Updated port can be obtained here: > http://intara.org.ru/tortoisehg1.shar > or from attachment. Some comments: - PORTNAME can be different with the path. PORTNAME=3Dtortoisehg is OK. - We usually use "USE_PYTHON=3Dyes" - It would be better to keep patches in *-patch: targets. Move "${REINPLACE_CMD}" actions to post-patch:. - If this port does not need to run configure or so. Use do-configure: @${DO_NADA} Regards, --=20 Sunpoet Po-Chuan Hsieh 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt