From nobody Tue May 20 07:15:18 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b1m6G5dTHz5vxNs; Tue, 20 May 2025 07:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b1m6G4sCrz3vK7; Tue, 20 May 2025 07:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747725318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S5o2JseuOUqRIlTvvjb+fF/QJ7yQXB+bTzsyMjmLJsE=; b=s1sj0UI7hDSLGIfIX3aVpxD3xwplAQyFFTkDjCf8vDm+s++JnMiMiwtUUwGL3UrmjgwXS1 58AkjVbbLG8pPzho12hH0C3A7cpIwC5KX0JW9WNmAnkg18pf/qcMiSBfxTDmcbUVx/IfgP 1VR4mEdDmZjX8Igt6qAaIwIAbUO67iic+ADGYiwgUuDvgCn8FMLiBbbbqt+SA4XXZKa+aX wD4YyFvXeyIBuq0SWNimVxOYeRlBYlTH6vXkhxslIm7H19qWCYr2mF9kpq0v6r0m1n9TLQ 7dJzYaepxJhi0ew4pDgVfnyqv+/yxvtexwDU15XE7CNJ0gzMCVjDRGH3v0ZRUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747725318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S5o2JseuOUqRIlTvvjb+fF/QJ7yQXB+bTzsyMjmLJsE=; b=UV5PZMi6SNqbuFNurqGtRk33+p0EMIMcmpgj2EKgOr2uuFYpIvC7xOJjKpMQA32+VbrPMQ 4Wmx35meuPT8IcDuEWPE7aGYwPqGWMSMqz0ewURDOltzPagWKVloD/JgMJ5/o9W+YeF4FC +6z2M1Gz2ZlYpw4EfQxmO6e/V9MbKyVpdnQuVHpzCBeG1Msd5XvZmEOR65/nHSRYjvzkIF JgzaJkL0RsOOaWEyzicbItkQ3yXBX5j0EuVlOkV26rAdHW8+CZNVxJHM7QVLim12EjJzSG 6aCE0hZVMQbaPConT8eZ7rX671RSPdwY4r3A9WCsCHu2KbSquJal/ONuE+uwqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747725318; a=rsa-sha256; cv=none; b=kqrzwlqL43VxZ+U8iCbPthVsdKvtljR6hQ0pKKiSNpHgQ8Pb5D774Tj7fVMzS5EV2qkLKV 2R2fvdA1k1dVc+tWdjgmnb4FUV0P95UnrD6cO1b+GUCT/n9VTpTkMN5HseuDBL0IoQyhtY lL7wRL7ulmQELBvmGs49LGqbvPtSCSJiktsWpKnnpTSFVTRzEaGfhPI/JCJ/B9tk9biI+W dLfVdO4vjnvXZ10yj9a6N40aXYXzcScdjPVOW1xwuN9MukuvhLEjGqxqf0aDR0b5AarvHX UHpZYE5dwJNKap81cV82tETYUhmF0qJZyLALKdkMnA9Zn6o+h2697hAWNoY6lA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b1m6G4K9BzgXV; Tue, 20 May 2025 07:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54K7FIgg094334; Tue, 20 May 2025 07:15:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54K7FIi8094331; Tue, 20 May 2025 07:15:18 GMT (envelope-from git) Date: Tue, 20 May 2025 07:15:18 GMT Message-Id: <202505200715.54K7FIi8094331@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: 0f941203ac51 - main - vm_page: drop mpred from grab_valid_iter() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0f941203ac513f5ed3cf30038ac9e7a062acf1b7 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=0f941203ac513f5ed3cf30038ac9e7a062acf1b7 commit 0f941203ac513f5ed3cf30038ac9e7a062acf1b7 Author: Doug Moore AuthorDate: 2025-05-20 07:11:40 +0000 Commit: Doug Moore CommitDate: 2025-05-20 07:14:49 +0000 vm_page: drop mpred from grab_valid_iter() Variable mpred in vm_page_grab_valid_iter() has become a write-only variable. Drop it. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50424 --- sys/vm/vm_page.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index ea6fbdbc6386..85a39aa8c22e 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -4880,7 +4880,7 @@ int vm_page_grab_valid_iter(vm_page_t *mp, vm_object_t object, vm_pindex_t pindex, int allocflags, struct pctrie_iter *pages) { - vm_page_t m, mpred; + vm_page_t m; vm_page_t ma[VM_INITIAL_PAGEIN]; int after, i, pflags, rv; @@ -4924,7 +4924,6 @@ retrylookup: *mp = NULL; return (VM_PAGER_FAIL); } else { - mpred = vm_radix_iter_lookup_lt(pages, pindex); m = vm_page_alloc_iter(object, pindex, pflags, pages); if (m == NULL) { if (!vm_pager_can_alloc_page(object, pindex)) { @@ -4941,7 +4940,7 @@ retrylookup: after = MIN(after, VM_INITIAL_PAGEIN); after = MIN(after, allocflags >> VM_ALLOC_COUNT_SHIFT); after = MAX(after, 1); - ma[0] = mpred = m; + ma[0] = m; pctrie_iter_reset(pages); for (i = 1; i < after; i++) { m = vm_radix_iter_lookup(pages, pindex + i); @@ -4952,7 +4951,6 @@ retrylookup: break; } else if (vm_page_any_valid(m) || !vm_page_tryxbusy(m)) break; - mpred = ma[i] = m; } after = i; vm_object_pip_add(object, after);