From owner-cvs-src Mon Feb 10 20: 4:25 2003 Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 4738837B401; Mon, 10 Feb 2003 20:04:23 -0800 (PST) Date: Mon, 10 Feb 2003 22:04:23 -0600 From: Juli Mallett To: Peter Wemm Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs Makefile mkfs.c newfs.c newfs.h ref.test Message-ID: <20030210220423.A36674@FreeBSD.org> References: <200302110306.h1B36k0p057099@repoman.freebsd.org> <20030211035711.22D9C2A8B4@canning.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030211035711.22D9C2A8B4@canning.wemm.org>; from peter@wemm.org on Mon, Feb 10, 2003 at 07:57:11PM -0800 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Peter Wemm [ Data: 2003-02-10 ] [ Subjecte: Re: cvs commit: src/sbin/newfs Makefile mkfs.c newfs.c newfs.h ref.test ] > Juli Mallett wrote: > > jmallett 2003/02/10 19:06:46 PST > > > > Modified files: > > sbin/newfs Makefile mkfs.c newfs.c newfs.h ref.test > > Log: > > Convert newfs to libufs (really). Solves one real issue with previous > > version of such. Differences in filesystems generated were found to be > > from 1) sbwrite with the "all" parameter 2) removal of writecache. The > > sbwrite call was made to perform as the original version, and otherwise > > this was checked against a version of newfs with the write cache removed. > > Umm, I object! This is a massive performance loss on disks without track > write buffering (eg: many raid systems).. While it isn't so bad for ufs2 > newfs, it is a Big Deal for ufs1 for interchangeability. OK. I was kind of hoping to put a general write cache (and since we do reads, a general buffer cache, in a sense) into libufs, but I suppose I could just put back the wc stuff, and avoid calling into libufs for anything other than bread/bwrite. Which would you prefer? Do you know of anything other than newfs where it matters? Thanx, juli. -- Juli Mallett AIM: BSDFlata -- IRC: juli on EFnet OpenDarwin, Mono, FreeBSD Developer ircd-hybrid Developer, EFnet addict FreeBSD on MIPS-Anything on FreeBSD To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message