From owner-svn-src-all@freebsd.org Sat Aug 20 18:02:17 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5014BC0E73; Sat, 20 Aug 2016 18:02:17 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 894B01F54; Sat, 20 Aug 2016 18:02:17 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-it0-x22c.google.com with SMTP id x131so55674631ite.0; Sat, 20 Aug 2016 11:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=v9OLQOo+Y0l3GbiUA62s4FVnJ1Hub/t1TivCgvOVANE=; b=MIjprukg6ab0dOlgKdz1MGws8kEtfnS8iN89W4LIOLepZJh1wjwU8AgtZn/vIqnq0P xUabxeDePw2sROqrxgPHCsh20ZdajQ422gHjSTIVtUcIxNWyOUAZItEcgIyVuw63l8Ok Ae7MBKkBWNAVr6TV0Qh0YxtjriDV1ISXA2LXFaVSNOXWsh9hn88CdQ//S/eKqoUzxMyB 01Y8R9Yw+KLXDuqyKyVKV8t8imzINaiSsHSOSgfqmuV3dEJntTRV2XIJEAUi2sOcOFX7 rn3ndlDvQMLfxp/2IaPO+uA/Yzphp+CVUkEyYUptYmVuLk3Vy/TIpeXiPrYNeDHqDcOe Jgrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=v9OLQOo+Y0l3GbiUA62s4FVnJ1Hub/t1TivCgvOVANE=; b=KmOQKxfo0TSILoywjwb2WCgtpQCvXLVbRCDMPeWFPUF77tRHURG3ZN97GfCQoegjuq qXuw8a+m3E79D6jtDk/yE+hJiP4NC638re0m9OaDP4JOqhfMFhtCxKmAz3FBBZbdstCu 6Pf9z3OROBoYkBOGfCd9e81t8iCb5Z9cnFQiHm7OPSKHZnRC0LZjv9UR1F+FJXl6hAac oINK0z97/D4NHK5VeI4Ws3qTL9fuenq1dXn9UPObMlXJSi0QJtpao8qhwmbMCzKbeOm7 fuOdqHOIwgyzzH+pgtaHSpgXJonvQuUqXwVC6k4cUZnJkF9ra4xsRyCCBFvn6YwwZ4Od /gtw== X-Gm-Message-State: AEkoousJ0lPSVKx13m7FujqwvueVTgZJhsXxhklQftnKW12iOdmrvGhYNn5gcgphpBW5HuHJYLMR0+Wc1oT08Q== X-Received: by 10.36.217.9 with SMTP id p9mr13165883itg.46.1471716136825; Sat, 20 Aug 2016 11:02:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.200.71 with HTTP; Sat, 20 Aug 2016 11:02:16 -0700 (PDT) In-Reply-To: <20160820173050.GQ22212@zxy.spb.ru> References: <201608182259.u7IMx5oW002018@repo.freebsd.org> <4fbc2e1d-3a62-5963-83d5-f9c931503e51@fastmail.net> <3806700d-ed27-7915-4818-c2d64f7b806d@fastmail.net> <6f4449f2-d145-8b49-c3f0-433e8ff4d2a2@fastmail.net> <20160820173050.GQ22212@zxy.spb.ru> From: Ryan Stone Date: Sat, 20 Aug 2016 14:02:16 -0400 Message-ID: Subject: Re: svn commit: r304436 - in head: . sys/netinet To: Slawa Olhovchenkov Cc: Bruce Simpson , "svn-src-head@freebsd.org" , Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Adrian Chadd Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2016 18:02:17 -0000 On Sat, Aug 20, 2016 at 1:30 PM, Slawa Olhovchenkov wrote: > For host enought have [hidden] alias with broadcsts bits. > Anyway, don't should relay on the L2 information, you can recive L3 > unicast addressed packets (with alien dst IP address) in L2 broadcas > packet. > This is still handled correctly. The new code only checks for L3 broadcast addresses on L2 broadcast packets, but we still check the L3 address before treating it as a broadcast. The problem is that I assumed that all paths into the IP stack would set M_BCAST, but as Bruce has pointed out there are cases like PPP which do not.