From owner-freebsd-hackers Wed Jul 18 2: 7:48 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from mailhub.fokus.gmd.de (mailhub.fokus.gmd.de [193.174.154.14]) by hub.freebsd.org (Postfix) with ESMTP id 3FE5637B406 for ; Wed, 18 Jul 2001 02:07:37 -0700 (PDT) (envelope-from brandt@fokus.gmd.de) Received: from beagle (beagle [193.175.132.100]) by mailhub.fokus.gmd.de (8.8.8/8.8.8) with ESMTP id LAA12077 for ; Wed, 18 Jul 2001 11:07:35 +0200 (MET DST) Date: Wed, 18 Jul 2001 11:07:35 +0200 (CEST) From: Harti Brandt To: Subject: Format checking for sbuf_printf... Message-ID: <20010718110432.P20739-100000@beagle.fokus.gmd.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hello, given that the various printf's in systm.h are format-checked, it probably makes sense to add this to sbuf_printf also. Could somebody please commit this? harti Index: sbuf.h =================================================================== RCS file: /usr/ncvs/src/sys/sys/sbuf.h,v retrieving revision 1.6 diff -c -r1.6 sbuf.h *** sbuf.h 2001/07/03 21:46:42 1.6 --- sbuf.h 2001/07/17 12:05:28 *************** *** 58,64 **** int sbuf_bcpy(struct sbuf *s, const char *str, size_t len); int sbuf_cat(struct sbuf *s, const char *str); int sbuf_cpy(struct sbuf *s, const char *str); ! int sbuf_printf(struct sbuf *s, const char *fmt, ...); int sbuf_putc(struct sbuf *s, int c); int sbuf_overflowed(struct sbuf *s); void sbuf_finish(struct sbuf *s); --- 58,64 ---- int sbuf_bcpy(struct sbuf *s, const char *str, size_t len); int sbuf_cat(struct sbuf *s, const char *str); int sbuf_cpy(struct sbuf *s, const char *str); ! int sbuf_printf(struct sbuf *s, const char *fmt, ...) __printflike(2, 3); int sbuf_putc(struct sbuf *s, int c); int sbuf_overflowed(struct sbuf *s); void sbuf_finish(struct sbuf *s); -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.gmd.de, harti@begemot.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message