From owner-freebsd-arch@FreeBSD.ORG Sun Aug 4 13:58:27 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DC9D51DA; Sun, 4 Aug 2013 13:58:27 +0000 (UTC) (envelope-from prvs=1928f37ee5=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 58ABF29FF; Sun, 4 Aug 2013 13:58:26 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50005326170.msg; Sun, 04 Aug 2013 14:58:24 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Sun, 04 Aug 2013 14:58:24 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=1928f37ee5=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <1A44B776F5B64F7494C52060B5B9ED73@multiplay.co.uk> From: "Steven Hartland" To: "Andriy Gapon" References: <51F67B2A.3040302@FreeBSD.org> <69CEF0CC3C8C4B9BBA8E3ACACB18DC2B@multiplay.co.uk> <51F6B5EF.5020407@FreeBSD.org> Subject: Re: translate INVARIANTS to DEBUG for code from OpenSolaris Date: Sun, 4 Aug 2013 14:59:05 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Aug 2013 13:58:27 -0000 ----- Original Message ----- From: "Andriy Gapon" >> I'm not sure you need #define ZFS_DEBUG as its already a dependency on >> DEBUG see: >> sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_debug.h > > Good point. Thank you. > >> Should this connection be broken and INVARIANTS only trigger DEBUG by >> default? One potential reason for this distinction is that ZFS_DEBUG brings >> with it some potentially quite heavy weight validation such as dnode_verify. >> >> If so I have small list of additional fixes here that where required when >> I tested enabling ASSERTS checking without ZFS_DEBUG. >> >> What do others think, should INVARIANTS trigger ZFS_DEBUG or should that >> be kept seperate? > > I would prefer to follow what upstream does in this respect. > If DEBUG implies ZFS_DEBUG upstream, then I think that we should do the same for > INVARIANTS -> DEBUG -> ZFS_DEBUG. > Unless there are strong reasons to do otherwise. Been testing this today including forcing a ZFS ASSERT violation and it all works as expected including not getting all the false positive LOR :) Do intend to get this committed in the near future? Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.