From owner-svn-ports-all@freebsd.org Fri Aug 31 20:41:49 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94EC0FDC292 for ; Fri, 31 Aug 2018 20:41:49 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc34.google.com (mail-yw1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3339C849D1 for ; Fri, 31 Aug 2018 20:41:49 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc34.google.com with SMTP id x67-v6so5519471ywg.0 for ; Fri, 31 Aug 2018 13:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gye5vIHRWlRXCyCnJ5RUax1NTJzOYLi94oicDvDSK00=; b=rJuYi0uNKhpPsI06ptwRwlVhWk0BXRd17Vxu5gnRmdG9jGPZlzLyhKuR0kQiisz4Jy YudsAnq5D5TkmyUMlSQpyI0h58sOAyV6HSLWe4WZl0YJ49/6Fl7NjoWKzImRy3JhVRFs iSxF7sHrDdFaefPMXfKbY5Fcit1V7/brwQ1wCHtkmtuh83Mnrp3kf1rDvAhDz4KB5DMG nKbMtumegh9fU5LwBefkbq85ZLUSZdmMtmE8F5XAULiIGzbisc+7CHza4VNI6L7cGwmv ZpeAh/qZgkZw1cr3uoWkfTCd32k8GYy2S4d2yN7pvxFgYDKfFNEGi7JGVbkRmFTppsFE 5WIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gye5vIHRWlRXCyCnJ5RUax1NTJzOYLi94oicDvDSK00=; b=QICCu7vCxUFpfYZGcHvXlinn/g8k4WSutREA+WUHAYh1TxNaYKJP51XMOOjIi3MP2R AlZjA3bioPLDS69e8shy2G/7KuWITA532aYJm5rPrCZAYvDyq6bfWkYT+71j3aDHPYd5 np20NRprMrBwYMgCPiPcEFBul1cPgk1ikpZZIVzuXWBz7FABKpMwsbigmRs2pDzbO5h+ onUdokHSNzRjfW6JQXybuqVqOyIA9vZ/0E2L47cYjHsep66cJtxPA443zyhM0qju+0Rr M9QnqVq+0lrH3GaD+yibDaUyQJlE451qqZT+CtAwijcYjoVgEwE9h9B7R76yFdEtLTYr ESGQ== X-Gm-Message-State: APzg51CBLu/weRZMHyF5RqAmJF6ipWVeiFey3sbmSu1gpj2oeUEsZo1+ VMs1MWF0kkr/6gD8XF2pDZpkIoI5IXnwEc5qVyH4+Q== X-Google-Smtp-Source: ANB0VdaIHbfvxgAYKVbEdM7k31eSyPDWuFpcMHfJOVQDIT7sR/Sm/1ZVRxwBDaXYodGCyukGGGFzenNAM5fC9g6YmWg= X-Received: by 2002:a81:67c6:: with SMTP id b189-v6mr10068396ywc.37.1535748108540; Fri, 31 Aug 2018 13:41:48 -0700 (PDT) MIME-Version: 1.0 References: <201808312014.w7VKEwAC012418@repo.freebsd.org> In-Reply-To: <201808312014.w7VKEwAC012418@repo.freebsd.org> From: Adam Weinberger Date: Fri, 31 Aug 2018 14:41:32 -0600 Message-ID: Subject: Re: svn commit: r478608 - head/devel/msgpack To: jbeich@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 20:41:49 -0000 On Fri, Aug 31, 2018 at 2:15 PM Jan Beich wrote: > > Author: jbeich > Date: Fri Aug 31 20:14:57 2018 > New Revision: 478608 > URL: https://svnweb.freebsd.org/changeset/ports/478608 > > Log: > devel/msgpack: restore TEST_TARGET after r470984 > > TEST_DEPENDS is pointless without do-test or TEST_TARGET. automake > required googletest only during "check" but cmake wants it upfront > during "test". So, move tests into a separate option. I don't get it. 130 ports out of 33,012 have TEST options. That's 0.3%. This sounds like your personal preference, not an "any maintainer would want this fixed" commit. OPTIONS are to let users customize the package, not to assist people who want to run their own regression tests. The fact that poudriere doesn't automatically run tests is not justification to adding a non-standard OPTION. If you want to test it in poudriere, run testport -i and run ctest yourself. Please back this out. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org