From owner-cvs-all Tue Mar 20 1:34:45 2001 Delivered-To: cvs-all@freebsd.org Received: from acampi.inet.it (acampi.inet.it [213.92.4.194]) by hub.freebsd.org (Postfix) with SMTP id 6A53537B721 for ; Tue, 20 Mar 2001 01:34:36 -0800 (PST) (envelope-from andrea@webcom.it) Received: (qmail 54968 invoked from network); 20 Mar 2001 10:33:21 -0000 Received: from brian.inet.it (HELO webcom.it) (213.92.4.195) by acampi.inet.it with SMTP; 20 Mar 2001 10:33:21 -0000 Received: (qmail 2553 invoked by uid 1000); 20 Mar 2001 09:31:14 -0000 Date: Tue, 20 Mar 2001 10:31:14 +0100 From: Andrea Campi To: Robert Watson Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/top machine.c Message-ID: <20010320103113.A1065@webcom.it> References: <200102231852.f1NIqcs45296@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200102231852.f1NIqcs45296@freefall.freebsd.org>; from rwatson@FreeBSD.org on Fri, Feb 23, 2001 at 10:52:38AM -0800 X-Echelon: BND CIA NSA Mossad KGB MI6 IRA detonator nuclear assault strike Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Modified files: > usr.bin/top machine.c > Log: > Adapt the top utility to not use kmem_read to retrieve variables now > available via sysctl(). As a result, top should now be able to run without > setgid kmem. > > Submitted by: Thomas Moestl > Reviewed by: freebsd-audit > > Revision Changes Path > 1.37 +44 -167 src/usr.bin/top/machine.c This commit breaks correct display of memory stats in top. Please try the enclosed patch; I tested this with tonight's -current. --- machine.c.orig Tue Mar 20 10:26:56 2001 +++ machine.c Tue Mar 20 10:27:35 2001 @@ -332,7 +332,12 @@ GETSYSCTL("vm.stats.vm.v_swappgsin", nspgsin); GETSYSCTL("vm.stats.vm.v_swappgsout", nspgsout); /* convert memory stats to Kbytes */ + memory_stats[0] = pagetok(memory_stats[0]); + memory_stats[1] = pagetok(memory_stats[1]); + memory_stats[2] = pagetok(memory_stats[2]); + memory_stats[3] = pagetok(memory_stats[3]); memory_stats[4] = bufspace / 1024; + memory_stats[5] = pagetok(memory_stats[5]); memory_stats[6] = -1; /* first interval */ -- Tagline generated by 'gensig' mail-client-independent .signature generator. Get your copy at http://www.geeks.com/~robf/gensig/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message