From nobody Wed Jun 21 10:26:22 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QmKRL4fqMz4gbVc for ; Wed, 21 Jun 2023 10:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QmKRL3dVkz3rqB for ; Wed, 21 Jun 2023 10:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687343182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PmqLg7l/aZOUymya/TLngVGq0v9rJDlLVt5GWuQBl8=; b=ALH3rr/0mMakKdwbwTMv8mRZjWFCH8R+pQzU5WFHAo2BQ+nNhLDUkg/kWeWw1jPzGpZsfb VmTv9U+PCX4T9f0ITPyAfg6nPFwU95Q5ttNNeGMzaJEZ+WjlnmgN0iEleoAF4xsfMOIMSw ItT0zGeL6u4996ZkBEnB2WTe+WLAWgbSxpIhImWQFJV5xroLuk/rdFtf0u1YhJ7YfXrbpF +nZHi5BDpwXHkWbkRF87T45qXh0zCXMCb3y/8c61rMy7vV3UF2y++bC4aRXkjy1y97W1Rf 8GsLkZqyiemPv13rqAM90Fy7xQzIOP2loMVYB+tfH4Je8+sSawtoNfuF9FlP/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687343182; a=rsa-sha256; cv=none; b=MvMTDddD28BahxwVP6IEOoTOXPfWHSQHO3pPS9f5My7OChdOCdkfZzKquZ2pc6+QXnd+iD GXraoK24L1VKIGlp6DrE9fR+WE8xnI8YchQUG0AAwsrfVbwC3UD1GCZ1fXMaFKXj1krzMl TPM62j8vOR9hAjZ2XL503MbDEDbBMH0j3g1dg0YyziemOrXGrheD7ZOm/+R1bJHkMpDe4B ROAqxdX44TSZbdRrBvs88WNsjXKDgNakknOclx9owjgfEuKscjyp9d08xmdvQsWfA6wPGA NjtfD88tDwPIT8Pfy5deJf/ijJuliI2tSEMspDnkvB3Qn2sTC1DE3HScmk+Ylg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QmKRL2hJ2zdTh for ; Wed, 21 Jun 2023 10:26:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35LAQMrd025180 for ; Wed, 21 Jun 2023 10:26:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35LAQMOx025179 for bugs@FreeBSD.org; Wed, 21 Jun 2023 10:26:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271764] buf_ring_dequeue_sc not holding strong for arm64 Azure Date: Wed, 21 Jun 2023 10:26:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271764 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D17050a2b5b07160635aaa80b9aa4df4de= 500b090 commit 17050a2b5b07160635aaa80b9aa4df4de500b090 Author: Wei Hu AuthorDate: 2023-06-21 09:31:46 +0000 Commit: Wei Hu CommitDate: 2023-06-21 10:10:49 +0000 Hyper-V: vmbus: Prevent load/store reordering when access ring buffer i= ndex When running VM on ARM64 Hyper-V, we have seen netvsc/hn driver hit assert on reading duplicated network completion packets over vmbus channel or one of the tx channels stalls completely. This seems to caused by processor reordering the instructions when vmbus driver reading or updating its channel ring buffer indexes. Fix this by using load acquire and store release instructions to enforce the order of these memory accesses. PR: 271764 Reported by: Souradeep Chakrabarti Reviewed by: Souradeep Chakrabarti Tested by: whu Sponsored by: Microsoft sys/dev/hyperv/vmbus/vmbus_br.c | 31 +++++++++++++++++-------------- sys/dev/hyperv/vmbus/vmbus_brvar.h | 6 ++++-- 2 files changed, 21 insertions(+), 16 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=