From owner-freebsd-current@FreeBSD.ORG Wed Aug 5 14:20:10 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85158106566C; Wed, 5 Aug 2009 14:20:10 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-bw0-f206.google.com (mail-bw0-f206.google.com [209.85.218.206]) by mx1.freebsd.org (Postfix) with ESMTP id CA1068FC1F; Wed, 5 Aug 2009 14:20:09 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by bwz2 with SMTP id 2so107780bwz.43 for ; Wed, 05 Aug 2009 07:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=YNDU4PpQs0ABcbzGJv1JU9qiVIZ22KG1E6IwuI2QJoQ=; b=BAH21jY2NwimiX3BtbeNnNOFr/8lFYrUPhPzrf7zuLJcIXOPiwxIXzHyMrN7XoaW8e vg3IcZnuuoRw6DRBje43ewSrbUoVkzgQJMIJ9AxYCMXuNSuXL8I7fx4zK18Si90jck59 eh5TCPljgi+MFSfY3VvORhSZ3RVQzcl9WvC2w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=HPkRdaCORyMO1eGg9ikDn05sc0HtS9/BgOTBc41GPeeh24u9pwaJuMARs/R5F0uUDN xm1Jh6QnTyZL17MVTlx08oOY0MosMrvW/u804GJx52xnetSz7sBkEve/peUGZ4FOiKRG HTzt9WjClc893jY8W+qp8cAZxl75jba6Ge3Ww= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.223.119.77 with SMTP id y13mr204542faq.4.1249482008494; Wed, 05 Aug 2009 07:20:08 -0700 (PDT) In-Reply-To: <200908051618.37902.hselasky@c2i.net> References: <90a5caac0908050258w1ea85736sac0b66ae5998e7de@mail.gmail.com> <200908051603.35169.hselasky@c2i.net> <3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com> <200908051618.37902.hselasky@c2i.net> Date: Wed, 5 Aug 2009 16:20:08 +0200 X-Google-Sender-Auth: e4901d201287070c Message-ID: <3bbf2fe10908050720s18580477qb3e58b066abdffc5@mail.gmail.com> From: Attilio Rao To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Ed Schouten , freebsd-current@freebsd.org, Robert Watson , Lucius Windschuh Subject: Re: uaudio attach panic: Giant not locked X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2009 14:20:10 -0000 2009/8/5 Hans Petter Selasky : > On Wednesday 05 August 2009 16:13:31 Attilio Rao wrote: >> 2009/8/5 Hans Petter Selasky : >> > On Wednesday 05 August 2009 13:43:11 Robert Watson wrote: >> >> On Wed, 5 Aug 2009, Ed Schouten wrote: >> >> > * Lucius Windschuh wrote: >> >> >> So I updated my machine to CURRENT r196062 and use a USB audio >> >> >> converter. Attaching it to the machine leads to a kernel panic: >> >> >> >> >> >> >> >> > >> >> > I suspect this has something to do with the Newbus locking, which >> >> > causes some pieces of code to run without Giant held, while they >> >> > previously did. >> >> >> >> There's a patch in the re@ queue to re-add Giant around newbus >> >> attachment, per John Baldwin's request. However, committing that patch >> >> is stalled while issues with the svn->cvs export of the new RELENG_8 >> >> branch are resolved. I expect to see the patch go into the tree RSN. >> > >> > Try this patch: >> > >> > http://perforce.freebsd.org/chv.cgi?CH=167030 >> >> Hans, >> I recall of a similar problem in ukbd. I resolved it by acquiring >> Giant earlier in ukbd_attach(), but probabilly I could just bring it >> down and pass a NULL pointer to usbd_do_transfer(), right? > > Yes, correct. > > I've changed the Giant mutex to a NULL one in USB P4. Maybe you can fix the > rest? > > http://perforce.freebsd.org/chv.cgi?CH=167032 Of course, thanks for the submissions. Attilio -- Peace can only be achieved by understanding - A. Einstein