From owner-freebsd-net Sun Feb 11 2: 0: 7 2001 Delivered-To: freebsd-net@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 4F2B837B401; Sun, 11 Feb 2001 01:59:49 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f1B9xnA18904; Sun, 11 Feb 2001 01:59:49 -0800 (PST) Date: Sun, 11 Feb 2001 01:59:49 -0800 From: Alfred Perlstein To: net@FreeBSD.ORG Cc: jlemon@FreeBSD.ORG Subject: Re: somaxconn and foot removal Message-ID: <20010211015949.K3274@fw.wintelcom.net> References: <20010211015516.J3274@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010211015516.J3274@fw.wintelcom.net>; from bright@wintelcom.net on Sun, Feb 11, 2001 at 01:55:16AM -0800 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org * Alfred Perlstein [010211 01:55] wrote: > The sysctl for somaxconn is an int, however the queue limits in the > socket structures are 'short' this can cause some bad behavior if > one sets somaxconn to more than 32k. > > A) So, do we bump the sockets to use 'int' for so->so_qlimit? > B) Do we fix solisten() to compensate? > C) Or de we fix the sysctl (patch below)? > > I have patches for A and C. Also note that I'd like to MFC this shortly which is why i'm a bit worried about mucking with socket/xsocket. I could use A for -current and C for -stable though. Let me know what sounds the best, also for C should I log(LOG_NOTICE or something? EINVAL is a bit cryptic. > (untested patch for A) > Index: socketvar.h > =================================================================== > RCS file: /home/ncvs/src/sys/sys/socketvar.h,v > retrieving revision 1.55 > diff -u -r1.55 socketvar.h -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message