From owner-svn-src-all@FreeBSD.ORG Tue Apr 13 09:18:54 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86CA4106564A; Tue, 13 Apr 2010 09:18:54 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 2E6D58FC24; Tue, 13 Apr 2010 09:18:53 +0000 (UTC) Received: by bwz8 with SMTP id 8so3950864bwz.3 for ; Tue, 13 Apr 2010 02:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=tHma7y76gWkRATNNSjSnj9ZUq+TQNOwPzJLs+5hPdBM=; b=PaHvgntbnJ2uYIVFHiC+XK5sjyFcKDdjD+wxH7ycfMfkXbWX1aktxKrgvLL2S5b3Mj 1tc7VYH/BHVdrjbr+jNoL7mY3sHxo3KJOMnRigvvods5Ier9q6gGe9I2ctcBUVVLw4kc M76HjG+zpzV6t0Y/mDRPykGvy1dLnUiqKvT1k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=bQlApyOwoNw7sC63La3wqfEMhBGENu0RxD11spC933VdvgG7iRMZ7AICz4rFsqLQaN PSi515h2jlQsoNkf+U/BAWzTUQ+YyAmqFC/Y76EVGZteIcuIaYUyPh5o1t3PQSrBN/f3 j7GMRjkr02SQkTPUlZRO35r7NZI0P58sJNBFA= Received: by 10.103.85.17 with SMTP id n17mr2854380mul.50.1271150332051; Tue, 13 Apr 2010 02:18:52 -0700 (PDT) Received: from [10.0.10.2] (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id b9sm22029756mug.13.2010.04.13.02.18.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Apr 2010 02:18:49 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <20100412210512.GB94885@onelab2.iet.unipi.it> Date: Tue, 13 Apr 2010 10:18:48 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <445CC969-4E21-4EA8-BE19-1754F4B2C583@freebsd.org> References: <201004121637.o3CGbjSK080066@svn.freebsd.org> <20100412204926.GB1743@garage.freebsd.pl> <20100412210512.GB94885@onelab2.iet.unipi.it> To: Luigi Rizzo X-Mailer: Apple Mail (2.1078) Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, Pawel Jakub Dawidek , svn-src-all@FreeBSD.org Subject: Re: svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2010 09:18:54 -0000 On 12 Apr 2010, at 22:05, Luigi Rizzo wrote: > On Mon, Apr 12, 2010 at 10:49:26PM +0200, Pawel Jakub Dawidek wrote: > ... >>> @@ -0,0 +1,19 @@ >>> +# GEOM_LIBRARY_PATH >>> +# $FreeBSD$ >>> + >>> +.PATH: /usr/src/sbin/geom/misc >>> + >>> +CFLAGS +=3D -I/usr/src/sbin/geom >>=20 >> This doesn't look right. >=20 > probably a leftover from older versions of this code for 6.x . > I will do more tests tomorrow (for 7.x at this point, there is > no point in trying to support 6.x I believe) and try to remove > it if not necessary. Even if you need geom/misc, this is not the correct way to include it. M=3D ${.CURDIR}/../../misc .PATH: ${M} CFLAGS+=3D-I${M} is probably what you want. There are many people out there (me included) = that don't use /usr/src. Regards, -- Rui Paulo