From owner-freebsd-current@FreeBSD.ORG Sun Feb 13 00:17:31 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 269CF16A4CE for ; Sun, 13 Feb 2005 00:17:31 +0000 (GMT) Received: from mail.mcneil.com (mcneil.com [24.199.45.54]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB9A443D41 for ; Sun, 13 Feb 2005 00:17:30 +0000 (GMT) (envelope-from sean@mcneil.com) Received: from localhost (localhost.mcneil.com [127.0.0.1]) by mail.mcneil.com (Postfix) with ESMTP id 5044DF3380; Sat, 12 Feb 2005 16:17:28 -0800 (PST) Received: from mail.mcneil.com ([127.0.0.1]) by localhost (server.mcneil.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 00718-07; Sat, 12 Feb 2005 16:17:27 -0800 (PST) Received: from [192.168.10.9] (unknown [192.168.10.9]) by mail.mcneil.com (Postfix) with ESMTP id D2418F337F; Sat, 12 Feb 2005 16:17:27 -0800 (PST) In-Reply-To: <1108248135.29089.12.camel@shumai.marcuscom.com> References: <576db86bb030e3cfe26a00b72f196d20@mcneil.com> <1108248135.29089.12.camel@shumai.marcuscom.com> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Sean McNeil Date: Sat, 12 Feb 2005 16:17:23 -0800 To: Joe Marcus Clarke X-Mailer: Apple Mail (2.619.2) X-Virus-Scanned: by amavisd-new at mcneil.com cc: current@freebsd.org Subject: Re: make broken in -current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Feb 2005 00:17:31 -0000 On Feb 12, 2005, at 2:42 PM, Joe Marcus Clarke wrote: > On Sat, 2005-02-12 at 14:21 -0800, Sean McNeil wrote: >> Even though it appears to work just fine on a make buildworld and for >> most things, make will sit in an infinite loop when I do the >> following: >> >> cd /usr/ports/shells/bash2 >> make distclean >> make >> >> when I cd to the work directory and do a make -d A I get the >> following: >> >> ... >> Global:GRAM_H = parser-built >> Global:.MAKEFILE_LIST = /usr/share/mk/sys.mk /etc/make.conf .. >> /usr/share/mk/bsd.compat.mk .. /usr/share/mk/bsd.cpu.mk .. .. Makefile >> .. >> Searching for .depend...failed. >> Searching for .depend.../usr/share/mk...failed. >> >> and stuck. >> >> a bt says it is sitting at /usr/src/usr.bin/make/main.c:821 >> >> This line looks bad. cp is incremented but ptr is the determinator. >> >> My machine is an amd64, but this code should cause problems for any >> machine. > > I reported this to harti last night. Attached is my proposed patch. > Thanks, Joe. This is what I did except I used "start" instead of a new variable "pptr". I think that there is another case above that does essentially the same thing. I'm not sure why it wasn't copied but instead done differently. Sean