From nobody Wed Jan 21 14:04:30 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dx5Xt4MWXz6PFjG for ; Wed, 21 Jan 2026 14:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dx5Xt1NBFz3Qgw for ; Wed, 21 Jan 2026 14:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769004270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yRBMOu6mpONK01WQ8romIEJ+ScgLOiloRnjHBQUWVEc=; b=rTlVhjFXhrb2km/nSuosaWNM/P1vUkgYaNxyPGNyA+KvJ+rzsqBE0p0kfksiZ6q4npIhAJ D9xRLwUIroE7m9JLXAiGoq+2cAzM6a1mIW3YcnanemuMxyQKFxpUdfFvjFwR4NCdxMDOHA fA0SjZryhmC3Sy3jB6JNvWmA5GsSk+qHXn3o8B1xK1vkDQnXVDCU5rspLvxdjPoFDWtM8+ dlW8dyTWUwzS/oW1TJQJt/am8g4SoffmmfejC+UFC8aOCrUg6bfAUB4uTc0aFBi0gmTDOP D+pnE/q6ULHL5SL6zK5FNpKShs+MKeUKNK2mn62t9TEQ2HE1nEk1PNsDuOdqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769004270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yRBMOu6mpONK01WQ8romIEJ+ScgLOiloRnjHBQUWVEc=; b=EUq0qEK0vBpSHGvTq8oo7JnRieKZCZuBury9o1Xu5EtREiRz6ZMnxE+iHPRK05unK0lxes 2SRpLZ/KAdpOj8V8e+MqIsxJ0oSIS/JS5KKtQPgO8WGmpZNLma6mf2TohtJaD4lOvt2/Yc b0apQuX8g39PUEZ/Wh6BSOal5CzFevpd77Y/i3R+nv7zwSqzQ8lG4TCeOEO4mrGSlXgEuu ZvsPJoLL9VhPhcB9xN9/FS2WCwpnPgStlm2592wYDYhhZVPN16uFb6q84mfl8VSStxr+wa L9CZmeFBjgsa45NIEeQzPwlKKbuIJig2SOjmqbRV7zAewxpJDuTuus5S5IEV+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769004270; a=rsa-sha256; cv=none; b=RM4l6dIiG033WcavtKC3V3f40UUpZPTlxyONL9ZsR/KF7dDL1amGAW4JOnyql10CDk+dwP V1C8MhOe9CbFRRrByEzE1E+eF7Fac8xML5h6ndiTQ83027DTZUGUqAJdvpqSYPZPrNU2qg +fWYMP5Gpb5UGXpmIEMmFjKzuVd4P/qGDwDFyTeqhPoTFo3pLvP7oM5kcuQ4buzxFsz00g /M5Xj8eaMRTjv017HTQ+Iiw9lVmFbo8152NrqVUd4PGpfobTNA0KV8JN+mVBHi36yl6Jkr nMw+KR0FNrPz8qrpzP3jcnunRdSqC8UkaDomM7ypTJXPFOK5SHEBWldBvs+4/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dx5Xt0yjqzr5r for ; Wed, 21 Jan 2026 14:04:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 216ab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 21 Jan 2026 14:04:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: a83f6427c15d - stable/14 - dwc: improve IPv4 transmit checksum offloading List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a83f6427c15d0ae24c89c583e72abab9a4669d8f Auto-Submitted: auto-generated Date: Wed, 21 Jan 2026 14:04:30 +0000 Message-Id: <6970dcee.216ab.711f4298@gitrepo.freebsd.org> The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=a83f6427c15d0ae24c89c583e72abab9a4669d8f commit a83f6427c15d0ae24c89c583e72abab9a4669d8f Author: Michael Tuexen AuthorDate: 2026-01-16 11:02:53 +0000 Commit: Michael Tuexen CommitDate: 2026-01-21 14:04:21 +0000 dwc: improve IPv4 transmit checksum offloading This patch provides two improvements for TCP/IPv4 and UDP/IPv4 transmit checksum offloading: (1) Use *CIC_SEG instead of *CIC_FULL, since FreeBSD always provides a pseudo header checksum. (2) Don't make transmit IPv4 header checksum offloading a prerequisite for TCP/IPv4 or UDP/IPv4 transmit checksum offloading. This is the root cause of PR 291696, since right now the epair interface does not support transmit IPv4 header checksum offloading, but TCP/IPv4 and UDP/IPv4 transmit checksum offloading. PR: 291696 Reviewed by: Timo Voelker Tested by: Marek Benc Differential Revision: https://reviews.freebsd.org/D54395 (cherry picked from commit f8ddf74175c8013268e65b18750e247306fa088a) --- sys/dev/dwc/if_dwc.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/sys/dev/dwc/if_dwc.c b/sys/dev/dwc/if_dwc.c index 18e86ac025d4..62de67653761 100644 --- a/sys/dev/dwc/if_dwc.c +++ b/sys/dev/dwc/if_dwc.c @@ -685,7 +685,7 @@ dwc_setup_txbuf(struct dwc_softc *sc, int idx, struct mbuf **mp) struct bus_dma_segment segs[TX_MAP_MAX_SEGS]; int error, nsegs; struct mbuf * m; - uint32_t flags = 0; + uint32_t flags; int i; int first, last; @@ -713,19 +713,12 @@ dwc_setup_txbuf(struct dwc_softc *sc, int idx, struct mbuf **mp) m = *mp; - if ((m->m_pkthdr.csum_flags & CSUM_IP) != 0) { - if ((m->m_pkthdr.csum_flags & (CSUM_TCP|CSUM_UDP)) != 0) { - if (sc->mactype != DWC_GMAC_EXT_DESC) - flags = NTDESC1_CIC_FULL; - else - flags = ETDESC0_CIC_FULL; - } else { - if (sc->mactype != DWC_GMAC_EXT_DESC) - flags = NTDESC1_CIC_HDR; - else - flags = ETDESC0_CIC_HDR; - } - } + if ((m->m_pkthdr.csum_flags & CSUM_DELAY_DATA) != 0) + flags = (sc->mactype != DWC_GMAC_EXT_DESC) ? NTDESC1_CIC_SEG : ETDESC0_CIC_SEG; + else if ((m->m_pkthdr.csum_flags & CSUM_IP) != 0) + flags = (sc->mactype != DWC_GMAC_EXT_DESC) ? NTDESC1_CIC_HDR : ETDESC0_CIC_HDR; + else + flags = (sc->mactype != DWC_GMAC_EXT_DESC) ? NTDESC1_CIC_NONE : ETDESC0_CIC_NONE; bus_dmamap_sync(sc->txbuf_tag, sc->txbuf_map[idx].map, BUS_DMASYNC_PREWRITE);