From owner-svn-ports-all@freebsd.org Fri Oct 4 02:30:02 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4182A147E81; Fri, 4 Oct 2019 02:30:02 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46kv3Y2fKmz3LGS; Fri, 4 Oct 2019 02:30:01 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf1-x42e.google.com with SMTP id y22so2954989pfr.3; Thu, 03 Oct 2019 19:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZjVT0lcuKOZl0SLHAXbqCh0TVTseDlsLYI6JGdheugI=; b=cBOV6WhInDCc9U7Xhci29jlrNWpaG58UaLkrerjAhoDaX6q5LrVzS9Nop1E/5HldKw aSvs8/P+quq0lo+ecqHDQxbucnRUTzyhjkntkTMFBA1fGZ7Y43sAynBFqy7Je6F+TLN8 m3rM6dc+891TXEnjm4+f7eTtrn6+qc8YGgjgfvyj5ZOAx4nCDoFmzHQuCDeIU1FA3SvH oMEjVdXHAZ/gwlsY5+1sF3iX+9mAjsQL5Fxh4PFyLDLH/JbO+JQU3D3M1608856Cw33b nW4Me/gLnRBhkaq6rVHFiPNkdSoMeI9hKWwALYZFzddg41Kb9lTmvCM22ocu3oMTQjXF 4/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZjVT0lcuKOZl0SLHAXbqCh0TVTseDlsLYI6JGdheugI=; b=LhtO3m+rNhwfdMcQilnTcl+eqtKQK0SciYSQWagVawB9c1c6nP2Pz/6KKwUiFp5egA FKb7rh+8/+txwznKNQTR35OdI0RwsAM8+i/h86N0N6+ib+pSlxPsnvAuF/YLpmIXKUQ7 GLoAGzq2w4mtSQGslZwNpgA1eKWccmUxCXge1i0pj0xWACp0eNNBU94BZ9pN7vJRX4m2 oc3vShp/0Jah35yrKewYvrKLpsfyEFd3VNphAt3ysv5vtKn9saYPP6Z1Rl83FHLoMR3Q ZYJU2LooW1jzxwWjeK4cngiIwAGqtKeTkPb5g/A1fidyLaSwvRI68TYx73uVolxrfLv8 Ktow== X-Gm-Message-State: APjAAAUEL8aYK1EgaC7quYrx/HNWWfXtq6S1eJmPZqgn5YQ1Cv9A3QgY TG/M9T0mNmWW9Yz9ENBnHdEpNfaG X-Google-Smtp-Source: APXvYqwp8gE0d9o9cBkw1/H5qJemZDnvCDJiOOJgl7W8XQiXxVzLGVTtLUIWbQsWhaISdqunzxxsdg== X-Received: by 2002:a63:6603:: with SMTP id a3mr12613766pgc.26.1570156199688; Thu, 03 Oct 2019 19:29:59 -0700 (PDT) Received: from [192.168.1.105] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id l72sm3924625pjb.7.2019.10.03.19.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 19:29:59 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r513663 - head/www/py-lektor To: =?UTF-8?Q?Vin=c3=adcius_Zavam?= , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201910031250.x93Coclr080961@repo.freebsd.org> From: Kubilay Kocak Message-ID: Date: Fri, 4 Oct 2019 12:29:55 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Thunderbird/70.0 MIME-Version: 1.0 In-Reply-To: <201910031250.x93Coclr080961@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46kv3Y2fKmz3LGS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cBOV6WhI; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::42e as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-4.90 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-2.70)[ip: (-8.74), ipnet: 2607:f8b0::/32(-2.57), asn: 15169(-2.16), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[e.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2019 02:30:02 -0000 On 3/10/2019 10:50 pm, Vinícius Zavam wrote: > Author: egypcio > Date: Thu Oct 3 12:50:38 2019 > New Revision: 513663 > URL: https://svnweb.freebsd.org/changeset/ports/513663 > > Log: > www/py-lektor: add devel/py-pip to RUN_DEPENDS > > - Makefile > based on upstream's setup.py, adding 'pip' to RUN_DEPENDS; > without 'pip' the lektor application wouldn't work as expected. > > https://github.com/lektor/lektor/blob/3.1.3/setup.py > > Modified: > head/www/py-lektor/Makefile > > Modified: head/www/py-lektor/Makefile > ============================================================================== > --- head/www/py-lektor/Makefile Thu Oct 3 11:18:02 2019 (r513662) > +++ head/www/py-lektor/Makefile Thu Oct 3 12:50:38 2019 (r513663) > @@ -2,6 +2,7 @@ > > PORTNAME= Lektor > PORTVERSION= 3.1.3 > +PORTREVISION= 1 > CATEGORIES= www devel python > MASTER_SITES= CHEESESHOP > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > @@ -20,7 +21,8 @@ RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}Jinja2>=2.4:devel/ > ${PYTHON_PKGNAMEPREFIX}Babel>=0:devel/py-babel@${PY_FLAVOR} \ > ${PYTHON_PKGNAMEPREFIX}setuptools>=0:devel/py-setuptools@${PY_FLAVOR} \ > ${PYTHON_PKGNAMEPREFIX}requests>=0:www/py-requests@${PY_FLAVOR} \ > - ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@${PY_FLAVOR} > + ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}pip>=0:devel/py-pip@${PY_FLAVOR} > > USES= python > USE_PYTHON= autoplist distutils > The only place pip is used is in WRKSRC/lektor/packages.py def download_and_install_package def install_local_package And pip should not be used to install dependencies pip should be removed from (patched out of) from install_requires and *_requires (extras_require, etc) used instead to describe additional/extra/non-compulsory dependencies) This should be sent/fixed upstream.