From owner-cvs-src@FreeBSD.ORG Tue Oct 26 16:40:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E635016A4CE; Tue, 26 Oct 2004 16:40:31 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E19F43D45; Tue, 26 Oct 2004 16:40:31 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9QGeT4v045812; Tue, 26 Oct 2004 18:40:29 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: John Baldwin From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 26 Oct 2004 12:19:03 EDT." <200410261219.03262.jhb@FreeBSD.org> Date: Tue, 26 Oct 2004 18:40:29 +0200 Message-ID: <45811.1098808829@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2004 16:40:32 -0000 In message <200410261219.03262.jhb@FreeBSD.org>, John Baldwin writes: >On Saturday 23 October 2004 04:21 pm, Poul-Henning Kamp wrote: >> phk 2004-10-23 20:21:05 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern vfs_mount.c >> Log: >> Drop Giant around the call to g_waitidle(). >> This is necessary to allow any geom events which need it to pick up >> Giant. > >tsleep() already automatically drops Giant for you, so this is not required >for geom events to run. Duh! I was wondering why it hadn't deadlocked... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.