From owner-svn-src-all@FreeBSD.ORG  Mon Apr 29 16:44:06 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C9F6E3E8;
 Mon, 29 Apr 2013 16:44:06 +0000 (UTC)
 (envelope-from hiren.panchasara@gmail.com)
Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47])
 by mx1.freebsd.org (Postfix) with ESMTP id 612D91F6B;
 Mon, 29 Apr 2013 16:44:05 +0000 (UTC)
Received: by mail-ee0-f47.google.com with SMTP id b57so2706590eek.20
 for <multiple recipients>; Mon, 29 Apr 2013 09:44:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=S8XiHZM4iCAAep0KgWL2zW8SaKjgmQUEGZf31E8oCPo=;
 b=J5GXfNYlA7eR/AzmQJuO74WnYoosgNZUhPjkcIbSv7+bXkX4LY4dBHxKK1eRPtAmHA
 D5QRP9D2YfacBVzXVSY8P+uKNELoVNb1YQuT6R57VtbmbWS+4jXOFvQNjg7E0VT4nvRQ
 /Wczo89BgcV+f+iam2fkskJvbPMzTe2ELuoZROS0fZLWuSrgB2RfhsyxMkjJW1DCrg7x
 KRAokhRhgEINPLzL5Mq1EvSUmmGk3ggd16RhB8be/bfSQLyOa1UXyA7W/OsHQNkeiZxB
 Mdg6KNQNV7FKNJ9VZwBtJurXp4bMzHRftVRLD2T5yoUlmzv/+MaBDg4gq3fG731FNINo
 uQcg==
MIME-Version: 1.0
X-Received: by 10.15.27.195 with SMTP id p43mr124194688eeu.8.1367253844359;
 Mon, 29 Apr 2013 09:44:04 -0700 (PDT)
Sender: hiren.panchasara@gmail.com
Received: by 10.14.204.200 with HTTP; Mon, 29 Apr 2013 09:44:04 -0700 (PDT)
In-Reply-To: <CAJ-Vmon_C2+OZNxH74A0mY=qf3E+m16aHwA8wri0xzJsfJ-LuA@mail.gmail.com>
References: <201304231302.r3ND2w5V024981@svn.freebsd.org>
 <CALCpEUExXu+CsM4ORr=Z=tMXvLJSqQn-sEOwY0aQ6GHCHeA50w@mail.gmail.com>
 <CALCpEUH2NZHpx6e7SCJRFkHZo2TOzXiZRFt_9UpgVO9+b13kFA@mail.gmail.com>
 <201304291123.41402.jhb@freebsd.org>
 <CAJ-Vmon_C2+OZNxH74A0mY=qf3E+m16aHwA8wri0xzJsfJ-LuA@mail.gmail.com>
Date: Mon, 29 Apr 2013 09:44:04 -0700
X-Google-Sender-Auth: adph2r6gHC0ONIGeDCu_lP9EvJQ
Message-ID: <CALCpEUG+gdg5W7JLRWCLQYY_DUJPgraZ3454g9tpQwwMcanSbg@mail.gmail.com>
Subject: Re: svn commit: r249800 - head/sys/dev/bwn
From: hiren panchasara <hiren@FreeBSD.org>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-head <svn-src-head@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 src-committers <src-committers@freebsd.org>, Eitan Adler <eadler@freebsd.org>,
 John Baldwin <jhb@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Apr 2013 16:44:06 -0000

On Mon, Apr 29, 2013 at 9:19 AM, Adrian Chadd <adrian@freebsd.org> wrote:
> On 29 April 2013 08:23, John Baldwin <jhb@freebsd.org> wrote:
>>> -       dr->setdesc(dr, desc, paddr, meta->mt_m->m_len -
>>> +       dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len -
>>>             sizeof(*hdr), 0, 0, 0);
>>>         return (error);
>>>  }
>>
>> I would leave the comment alone.  In the common case you do allocate a new
>> mbuf so you aren't restoring the descriptor but setting it up with a new
>> address.  The code change looks correct.

Alright. Thanks John.
>
> Does anyone here have bwn hardware that works?

I do not.

Hiren
>
>
>
> Adrian