From nobody Sun Feb 27 01:31:05 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4DFA819EAFA4; Sun, 27 Feb 2022 01:31:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K5mDn1lD3z3mJx; Sun, 27 Feb 2022 01:31:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645925465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aZndIaMm77ts7WwmfwnHbsdrGZ77k6l+S9uZvXS4C8k=; b=w4xeMuS7o9N5Vfjbt9u1bKMciAT2+pQ/ddcQc8iTYExfiUrlVCyoMtOY1K6nWMsTwHd7Fn WdVoNoDECuZ//byiV6q/qwM/ywEiHZSpchf9eN3AJkzztZy+8bVNeqdsVF9nUSTuvL/4JZ Bja1l4UxaLOTJXenKq/6uvr63biT/S3W+ypElM3/hUoN7mw3tTY3pJg/CUrGiSS1lUMWZZ LtKa4QyUIGfvBwM20jk3jDH0sJIHrjCvU1L4dTzFp76D88IIdq0jkazxPRKdpIdohqBjRJ +Xb7ivpOObAKi9BT+EfP5XOfN+HrShdEz4yrNz5P5AlgO/cqCffI5hQ9oh/REA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1C78D1DE68; Sun, 27 Feb 2022 01:31:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21R1V5EH015180; Sun, 27 Feb 2022 01:31:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21R1V5vo015179; Sun, 27 Feb 2022 01:31:05 GMT (envelope-from git) Date: Sun, 27 Feb 2022 01:31:05 GMT Message-Id: <202202270131.21R1V5vo015179@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Scott Long Subject: git: 6f3c0d2764f2 - main - Default to always accepting the PHY that's present. Linux did something similar a while back, and there are devices in the wild that otherwise won't attach. This patch is temporary until the PHY code is further cleared up. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: scottl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6f3c0d2764f230444818a95009028861493c1594 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645925465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aZndIaMm77ts7WwmfwnHbsdrGZ77k6l+S9uZvXS4C8k=; b=LR5IDQjWKQQGk1JOAE8pQCFQdq1KoLAIb1IOWIC6Eb1aHqBuOZbP+RK34e0CcKMxh6rWXg FKwAIQLV/hYkYPB3g4QpLvqjorIVc3ep4P0Su9JTNA+u4onkqmBVgTuUzSwu50b6knbJwD 0EkYgGftrgXPOnhjRlG9aEW4T5I1d47WdaeZtcNvb5N85YibcVfRu/EscsjH3R3JEbRZpB ORzkrcQBPwaplwCPDmXvUqksJy+Y2e4vRcRM5lN1Iv4881474dppjs20QiXqUca1NY8kOO 6CA5OdQ6i1RzbdO76lVjvNf2/ea4IZLwZNAFdY/1fi2FiOYLK6bd6NMYqJZljg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645925465; a=rsa-sha256; cv=none; b=FQhRQ/8IuzpBNzell2vJexWyP4y3OtU9vn+8DQE6jmJLXuqOm4XeKQD+s5S7eqUWrWtC5z 5rWkyLcoPGcT255y1Ew5HXjlClURegq4Z7nbtgOTFnexxRjQKbU7vQY+zem9jx9WvqH+zy h5D0MTyvwxCQjNMzbXRICBWIVzvdFrZnTZ6rBWV8QjP/i9coOgLQa/2hPVLrVlqcsngfqW OOpWmBfgUdCIAZBYNWlWwiaU+PYeCtdwlCeFyba5rBHB+wyOT/OEUvA9XEcp+EhWu09kUt QOp3pgu7GTyhQGfX31MpHp/Ic6HBsAajYYKk8hlUrBcQwnFD9sEXZ8wdgCjzpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by scottl: URL: https://cgit.FreeBSD.org/src/commit/?id=6f3c0d2764f230444818a95009028861493c1594 commit 6f3c0d2764f230444818a95009028861493c1594 Author: Scott Long AuthorDate: 2022-02-27 01:29:08 +0000 Commit: Scott Long CommitDate: 2022-02-27 01:29:08 +0000 Default to always accepting the PHY that's present. Linux did something similar a while back, and there are devices in the wild that otherwise won't attach. This patch is temporary until the PHY code is further cleared up. Obtained from: grehan --- sys/dev/igc/igc_i225.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/igc/igc_i225.c b/sys/dev/igc/igc_i225.c index 4c50daa16b79..95d7d1536184 100644 --- a/sys/dev/igc/igc_i225.c +++ b/sys/dev/igc/igc_i225.c @@ -172,14 +172,12 @@ static s32 igc_init_phy_params_i225(struct igc_hw *hw) /* Verify phy id and set remaining function pointers */ switch (phy->id) { case I225_I_PHY_ID: + default: phy->type = igc_phy_i225; phy->ops.set_d0_lplu_state = igc_set_d0_lplu_state_i225; phy->ops.set_d3_lplu_state = igc_set_d3_lplu_state_i225; /* TODO - complete with GPY PHY information */ break; - default: - ret_val = -IGC_ERR_PHY; - goto out; } out: