Date: Tue, 4 Jul 2023 04:15:57 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <1819984925.2142325.1688444157561@mail.yahoo.com> In-Reply-To: <20230703211340.1a26d3fa@slippy> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> <1767168745.2134945.1688443634249@mail.yahoo.com> <20230703211340.1a26d3fa@slippy>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
It's not broken, ... but OK, I am working on it now.
Pedro.
On Monday, July 3, 2023 at 11:13:44 PM GMT-5, Cy Schubert <cy.schubert@cschubert.com> wrote:
On Tue, 4 Jul 2023 04:07:14 +0000 (UTC)
Pedro Giffuni <pfg@freebsd.org> wrote:
> (Sorry for top posting)
> Oh yes, the analysis is fine, and it is quicker to fix than what I had in mind.
> I'll take a look at fixing it now, but due to external issues I may have to leave the fix for next weekend.
> Pedro.
You can't leave the tree broken for 5-7 days. Can you?
--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org
NTP: <cy@nwtime.org> Web: https://nwtime.org
e^(i*pi)+1=0
>
> On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <imp@bsdimp.com> wrote:
>
>
>
> On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
>
> Hmm ...
> Dragonfly has no armv7 or i386, so they didn't get it too wrong.I guess the int64_t would be a quick fix or another option, which I was consideirng, was to look at unsigning it but taking care of the edge cases ... I was too lazy for that.
> Please go ahead and do the quick fix ;)
>
> What makes you say it's a quick fix? If the calculations need 64 bits, int64_t is the proper data type. How is that analysis wrong?
> Also, it's tradition that you should fix it...
> Warner
[-- Attachment #2 --]
<html><head></head><body><div class="ydpbb76047eyahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div>
<div dir="ltr" data-setdir="false">It's not broken, ... but OK, I am working on it now.</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Pedro.</div><div><br></div>
</div><div id="ydp32720b06yahoo_quoted_8687646853" class="ydp32720b06yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Monday, July 3, 2023 at 11:13:44 PM GMT-5, Cy Schubert <cy.schubert@cschubert.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div dir="ltr">On Tue, 4 Jul 2023 04:07:14 +0000 (UTC)<br clear="none">Pedro Giffuni <<a shape="rect" href="mailto:pfg@freebsd.org" rel="nofollow" target="_blank">pfg@freebsd.org</a>> wrote:<br clear="none"><br clear="none">> (Sorry for top posting)<br clear="none">> Oh yes, the analysis is fine, and it is quicker to fix than what I had in mind.<br clear="none">> I'll take a look at fixing it now, but due to external issues I may have to leave the fix for next weekend.<br clear="none">> Pedro.<br clear="none"><br clear="none">You can't leave the tree broken for 5-7 days. Can you?<br clear="none"><br clear="none"><br clear="none">-- <br clear="none">Cheers,<br clear="none">Cy Schubert <<a shape="rect" href="mailto:Cy.Schubert@cschubert.com" rel="nofollow" target="_blank">Cy.Schubert@cschubert.com</a>><br clear="none">FreeBSD UNIX: <<a shape="rect" href="mailto:cy@FreeBSD.org" rel="nofollow" target="_blank">cy@FreeBSD.org</a>> Web: <a shape="rect" href="https://FreeBSD.org" rel="nofollow" target="_blank">https://FreeBSD.org</a><br clear="none">NTP: <<a shape="rect" href="mailto:cy@nwtime.org" rel="nofollow" target="_blank">cy@nwtime.org</a>> Web: <a shape="rect" href="https://nwtime.org" rel="nofollow" target="_blank">https://nwtime.org</a><br clear="none"><br clear="none"> e^(i*pi)+1=0<div class="ydp32720b06yqt6228578687" id="ydp32720b06yqtfd01641"><br clear="none"><br clear="none">> <br clear="none">> On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <<a shape="rect" href="mailto:imp@bsdimp.com" rel="nofollow" target="_blank">imp@bsdimp.com</a>> wrote: <br clear="none">> <br clear="none">> <br clear="none">> <br clear="none">> On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <<a shape="rect" href="mailto:pfg@freebsd.org" rel="nofollow" target="_blank">pfg@freebsd.org</a>> wrote:<br clear="none">> <br clear="none">> Hmm ...<br clear="none">> Dragonfly has no armv7 or i386, so they didn't get it too wrong.I guess the int64_t would be a quick fix or another option, which I was consideirng, was to look at unsigning it but taking care of the edge cases ... I was too lazy for that.<br clear="none">> Please go ahead and do the quick fix ;)<br clear="none">> <br clear="none">> What makes you say it's a quick fix? If the calculations need 64 bits, int64_t is the proper data type. How is that analysis wrong?<br clear="none">> Also, it's tradition that you should fix it...<br clear="none">> Warner <br clear="none"><br clear="none"></div></div></div>
</div>
</div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1819984925.2142325.1688444157561>