Date: Tue, 4 Jul 2023 04:15:57 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <1819984925.2142325.1688444157561@mail.yahoo.com> In-Reply-To: <20230703211340.1a26d3fa@slippy> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> <1767168745.2134945.1688443634249@mail.yahoo.com> <20230703211340.1a26d3fa@slippy>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_2142324_1520604610.1688444157560
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
It's not broken, ... but OK, I am working on it now.
Pedro.
On Monday, July 3, 2023 at 11:13:44 PM GMT-5, Cy Schubert <cy.schubert@=
cschubert.com> wrote: =20
=20
On Tue, 4 Jul 2023 04:07:14 +0000 (UTC)
Pedro Giffuni <pfg@freebsd.org> wrote:
>=C2=A0 (Sorry for top posting)
> Oh yes, the analysis is fine, and it is quicker to fix than what I had in=
mind.
> I'll take a look at fixing it now, but due to external issues I may have =
to leave the fix for next weekend.
> Pedro.
You can't leave the tree broken for 5-7 days. Can you?
--=20
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 Web:=C2=A0 https://FreeBSD.org
NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <cy@nwtime.org>=C2=A0 =C2=A0 Web:=C2=
=A0 https://nwtime.org
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 e^(i*pi)+1=3D0
>=20
>=C2=A0 =C2=A0 On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <i=
mp@bsdimp.com> wrote:=C2=A0=20
>=C2=A0=20
>=C2=A0=20
>=20
> On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
>=20
>=C2=A0 Hmm ...
> Dragonfly has no armv7 or i386, so they didn't get it too wrong.I guess=
=C2=A0the int64_t would be a quick fix or another option, which I was consi=
deirng, was to look at unsigning it but taking care of the edge cases ... I=
was too lazy for that.
> Please go ahead and do the quick fix ;)
>=20
> What makes you say it's a quick fix? If the calculations need 64 bits, in=
t64_t is the proper data type. How is that analysis wrong?
> Also, it's tradition that you should fix it...
> Warner=C2=A0=20
=20
------=_Part_2142324_1520604610.1688444157560
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<html><head></head><body><div class=3D"ydpbb76047eyahoo-style-wrap" style=
=3D"font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px=
;"><div></div>
<div dir=3D"ltr" data-setdir=3D"false">It's not broken, ... but OK,=
I am working on it now.</div><div dir=3D"ltr" data-setdir=3D"false"><br></=
div><div dir=3D"ltr" data-setdir=3D"false">Pedro.</div><div><br></div>
=20
</div><div id=3D"ydp32720b06yahoo_quoted_8687646853" class=3D"ydp32=
720b06yahoo_quoted">
<div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s=
ans-serif;font-size:13px;color:#26282a;">
=20
<div>
On Monday, July 3, 2023 at 11:13:44 PM GMT-5, Cy Schube=
rt <cy.schubert@cschubert.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div dir=3D"ltr">On Tue, 4 Jul 2023 04:07:14 +0000 (UT=
C)<br clear=3D"none">Pedro Giffuni <<a shape=3D"rect" href=3D"mailto:pfg=
@freebsd.org" rel=3D"nofollow" target=3D"_blank">pfg@freebsd.org</a>> wr=
ote:<br clear=3D"none"><br clear=3D"none">> (Sorry for top posting=
)<br clear=3D"none">> Oh yes, the analysis is fine, and it is quicker to=
fix than what I had in mind.<br clear=3D"none">> I'll take a look at fi=
xing it now, but due to external issues I may have to leave the fix for nex=
t weekend.<br clear=3D"none">> Pedro.<br clear=3D"none"><br clear=3D"non=
e">You can't leave the tree broken for 5-7 days. Can you?<br clear=3D"none"=
><br clear=3D"none"><br clear=3D"none">-- <br clear=3D"none">Cheers,<br cle=
ar=3D"none">Cy Schubert <<a shape=3D"rect" href=3D"mailto:Cy.Schubert@cs=
chubert.com" rel=3D"nofollow" target=3D"_blank">Cy.Schubert@cschubert.com</=
a>><br clear=3D"none">FreeBSD UNIX: <<a shape=3D"rect" href=3D"=
mailto:cy@FreeBSD.org" rel=3D"nofollow" target=3D"_blank">cy@FreeBSD.org</a=
>> Web: <a shape=3D"rect" href=3D"https://FreeBSD.org" rel=
=3D"nofollow" target=3D"_blank">https://FreeBSD.org</a><br clear=3D"none">N=
TP: <<a shape=3D"rect" href=3D"mailto=
:cy@nwtime.org" rel=3D"nofollow" target=3D"_blank">cy@nwtime.org</a>>&nb=
sp; Web: <a shape=3D"rect" href=3D"https://nwtime.org" rel=3D"=
nofollow" target=3D"_blank">https://nwtime.org</a><br clear=3D"none"><br cl=
ear=3D"none"> e^(i*=
pi)+1=3D0<div class=3D"ydp32720b06yqt6228578687" id=3D"ydp32720b06yqtfd0164=
1"><br clear=3D"none"><br clear=3D"none">> <br clear=3D"none">> =
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <<a s=
hape=3D"rect" href=3D"mailto:imp@bsdimp.com" rel=3D"nofollow" target=3D"_bl=
ank">imp@bsdimp.com</a>> wrote: <br clear=3D"none">> <br =
clear=3D"none">> <br clear=3D"none">> <br clear=3D"none">> O=
n Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <<a shape=3D"rect" href=3D"mai=
lto:pfg@freebsd.org" rel=3D"nofollow" target=3D"_blank">pfg@freebsd.org</a>=
> wrote:<br clear=3D"none">> <br clear=3D"none">> Hmm ...<br=
clear=3D"none">> Dragonfly has no armv7 or i386, so they didn't get it =
too wrong.I guess the int64_t would be a quick fix or another option, =
which I was consideirng, was to look at unsigning it but taking care of the=
edge cases ... I was too lazy for that.<br clear=3D"none">> Please go a=
head and do the quick fix ;)<br clear=3D"none">> <br clear=3D"none">>=
What makes you say it's a quick fix? If the calculations need 64 bits, int=
64_t is the proper data type. How is that analysis wrong?<br clear=3D"none"=
>> Also, it's tradition that you should fix it...<br clear=3D"none">>=
Warner <br clear=3D"none"><br clear=3D"none"></div></div></div>
</div>
</div></body></html>
------=_Part_2142324_1520604610.1688444157560--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1819984925.2142325.1688444157561>