From owner-svn-src-head@freebsd.org Tue Nov 24 09:21:17 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCE19A36F7D; Tue, 24 Nov 2015 09:21:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 54F491BD3; Tue, 24 Nov 2015 09:21:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tAO9LBvs069449 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 24 Nov 2015 11:21:11 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tAO9LBvs069449 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tAO9LBLx069448; Tue, 24 Nov 2015 11:21:11 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 24 Nov 2015 11:21:11 +0200 From: Konstantin Belousov To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291242 - head/sys/powerpc/include Message-ID: <20151124092111.GF58629@kib.kiev.ua> References: <201511240913.tAO9DLUC032185@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201511240913.tAO9DLUC032185@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 09:21:17 -0000 On Tue, Nov 24, 2015 at 09:13:21AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Tue Nov 24 09:13:21 2015 > New Revision: 291242 > URL: https://svnweb.freebsd.org/changeset/base/291242 > > Log: > On PowerPC 64bit, the linux-compat mb() definition is implemented with > lwsync instruction, which does not provide Store/Load barrier. Fix > this by using "full" sync barrier for mb(). > > atomic_store_rel() does not need full barrier, change mb() call there > to the lwsync instruction if not hitting the known CPU erratas > (i.e. on 32bit). Provide powerpc_lwsync() helper to isolate the > lwsync/sync compile time selection, and use it in atomic_store_rel() > and several other places which duplicate the code. Note that powerpc/aim/slb.c issues mb() also intending to generate lwsync. This will be fixed to use powerpc_lwsync() in the separate commit.