From owner-cvs-all@FreeBSD.ORG  Mon May 10 06:13:13 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8789C16A4CE; Mon, 10 May 2004 06:13:13 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 55C3243D45; Mon, 10 May 2004 06:13:13 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 5235B5C840; Mon, 10 May 2004 06:13:13 -0700 (PDT)
Date: Mon, 10 May 2004 15:13:13 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Eivind Eklund <eivind@FreeBSD.org>
Message-ID: <20040510131313.GG700@elvis.mu.org>
References: <200405101150.i4ABoL9V065750@repoman.freebsd.org>
	<20040510115040.2BD4B16A53F@hub.freebsd.org>
	<20040510130612.GA14041@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040510130612.GA14041@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/led led.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 May 2004 13:13:13 -0000

Eivind Eklund wrote:
> Not a big deal, but a minor style issue:
> 
> On Mon, May 10, 2004 at 04:50:40AM -0700, Maxime Henrion wrote:
> >   - Fix some style bugs while I'm here.
> 
> [...]
> 
> > -#endif /* _DEV_LED_H */
> > +#endif
> 
> Based in my presently installed /usr/include/sys, the style statistics
> for /usr/include/sys/*.h is as follows:
> 
> #endif		#endif /* _DEV_LED_H */		#endif /* !_DEV_LED_H */
> 28		52				148
> 12%		23%				65%
> 
> The removal of /* _DEV_LED_H */ from the last #endif brings it from an
> uncommon style to an even less common style.

Both styles are allowed by style(9) under different circumstances.  If the
#ifdef'ed block is big, then you should add the /* FOO_H */ comment.  If
it's not, you shouldn't put it, hence why I removed it.  So this isn't a
matter of which style is used most :-).

Cheers,
Maxime