From owner-svn-src-head@freebsd.org Tue Apr 26 00:29:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 499AFB1CDEE; Tue, 26 Apr 2016 00:29:37 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x22d.google.com (mail-ob0-x22d.google.com [IPv6:2607:f8b0:4003:c01::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B99114A3; Tue, 26 Apr 2016 00:29:37 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-ob0-x22d.google.com with SMTP id n10so78590379obb.2; Mon, 25 Apr 2016 17:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc; bh=uGCTAG03vnofk5Z1QY1welEOUdQW1nsA8XOMmUst1n0=; b=pr48yFxy+O5AnTBavv4UmeZcXhF3ZPw10I17BiuoLd5/C3gRoOSoVVY8vcVj3l99KZ LY8C2h2SliWaJaEsvgVAC6cTiuCwF3FQsnUOOkNq7utTjbOuk+chT0rh9FMA8kIS2ST9 cLBZxf4OodcWXufU8HVG9aiKggjYMQ8yqdx+8HIhcRnlP0bwIv+poPHcQMPIv3koC61O YSoGtLRV8WHpqZcouC30yrGctpzeqELTwPaGpSXw61OR89bqd+eIofl9d4ClJr/K53ZS IJgu7unvIVpkGtd+t1gXvu+CJIzlTuUfYUV9pgIqUArFMhAS1+kdlVAFThoH0k+LPvTq DN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=uGCTAG03vnofk5Z1QY1welEOUdQW1nsA8XOMmUst1n0=; b=CmdJiPe0FetpmAGAQVFza447YYARYKZNyNoGwbCYyOYkRtq4m3qrDWlnmCpttvcG+9 4Rx9E8822iNlmnUWQv2t79nBgHiJG0TMYaHSi+z8IuydbRek+3VSHtsueljWr+c1Zrwl p+GSpegRbauijDGYpFDHILV7JbpRg2mNEOzubEplPabZ+iFKAnmSm44NCr/Gq+3eiUhT umyg2aMn6yrB7Vs7E21lRe29A/uHCiNKV89WUeuuJNkfbKNWvKACpq6LZl/w6e4qu8nT uzfQT2K3LWZYV6yMOcuYBEFMlzzykZBF/wLshZeL492eEueHlwjQBSGfMrzL4ufE5bdk yqbQ== X-Gm-Message-State: AOPr4FXH7skn2DBfHMTcoDGmFMaMung9+ev+5x4T8UMC5Bkz6gYTLpFZ1Kj+RD3MNmFk9m3VBsB7mr8YQgLP/w== MIME-Version: 1.0 X-Received: by 10.182.182.35 with SMTP id eb3mr15878140obc.64.1461630576357; Mon, 25 Apr 2016 17:29:36 -0700 (PDT) Received: by 10.182.156.65 with HTTP; Mon, 25 Apr 2016 17:29:36 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <571E2AF2.2060300@FreeBSD.org> References: <201604220343.u3M3h69m058753@repo.freebsd.org> <571E2AF2.2060300@FreeBSD.org> Date: Tue, 26 Apr 2016 08:29:36 +0800 Message-ID: Subject: Re: svn commit: r298443 - head/usr.bin/stat From: Marcelo Araujo To: Pedro Giffuni Cc: luke , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 00:29:37 -0000 2016-04-25 22:34 GMT+08:00 Pedro Giffuni : > Marcelo, please revert. > > And check your script, of course. > Fixed thanks! The problem is the weird way the expression was wrote before. Best, > > Pedro. > > > On 23/04/2016 04:23, luke wrote: > > On Fri, Apr 22, 2016 at 11:43 AM, Marcelo Araujo < > araujo@freebsd.org> wrote: > >> Author: araujo >> Date: Fri Apr 22 03:43:06 2016 >> New Revision: 298443 >> URL: https://svnweb.freebsd.org/changeset/base/298443 >> >> Log: >> Use macro MAX() from sys/param.h. >> >> MFC after: 2 weeks. >> >> Modified: >> head/usr.bin/stat/stat.c >> >> Modified: head/usr.bin/stat/stat.c >> >> ============================================================================== >> --- head/usr.bin/stat/stat.c Fri Apr 22 03:37:27 2016 (r298442) >> +++ head/usr.bin/stat/stat.c Fri Apr 22 03:43:06 2016 (r298443) >> @@ -1025,7 +1025,7 @@ format1(const struct stat *st, >> * >> * Nanoseconds: long. >> */ >> - (void)snprintf(tmp, sizeof(tmp), "%dld", prec > 9 ? 9 : >> prec); >> + (void)snprintf(tmp, sizeof(tmp), "%dld", MAX(9, prec)); >> (void)strcat(lfmt, tmp); >> >> /* >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to " >> svn-src-head-unsubscribe@freebsd.org" >> > > > Hi, > > Should this be MIN() ? > > (void)snprintf(tmp, sizeof(tmp), "%dld", MIN(prec, 9)); > > > -- > Chang-Hsien Tsai > > > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)