From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 24 12:59:01 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73BFB16A401 for ; Mon, 24 Apr 2006 12:59:01 +0000 (UTC) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (goofy.demon.nl [83.160.134.92]) by mx1.FreeBSD.org (Postfix) with ESMTP id A82B143D48 for ; Mon, 24 Apr 2006 12:59:00 +0000 (GMT) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (localhost [127.0.0.1]) by goofy.tols.org (8.13.4/8.13.4) with ESMTP id k3OCwwS7037359 for ; Mon, 24 Apr 2006 12:58:58 GMT (envelope-from marco@goofy.tols.org) Received: (from marco@localhost) by goofy.tols.org (8.13.4/8.13.4/Submit) id k3OCwvfR037358 for freebsd-hackers@freebsd.org; Mon, 24 Apr 2006 12:58:57 GMT (envelope-from marco) Date: Mon, 24 Apr 2006 12:58:57 +0000 From: Marco van Tol To: freebsd-hackers@freebsd.org Message-ID: <20060424125857.GD36281@tols.org> Mail-Followup-To: freebsd-hackers@freebsd.org References: <20060412215021.GB1146@tols.org> <20060420224049.GA99399@tols.org> <20060423113335.GA27406@tols.org> <200604240823.48948.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200604240823.48948.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV 0.88.1/1423/Mon Apr 24 08:24:11 2006 on goofy.tols.org X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on goofy.tols.org Subject: Re: Per CPU cpu-statistics under SMP X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2006 12:59:01 -0000 On Mon, Apr 24, 2006 at 08:23:48AM -0400, John Baldwin wrote: > On Sunday 23 April 2006 07:33 am, Marco van Tol wrote: [...] > > Is there anything you can say regarding an estimate on when per-cpu > > specific stats will hit the official CURRENT and STABLE branches? > > > > Are you interested in what I did to gkrellm so far? All that was necessary > > was a small patch to src/sysdeps/freebsd.c in the gkrellm tree as far as > > making it work with your patch was concerned. I can send the patch to your > > email adres, or make it available on my website. :) > > Well, the goal of the patch was to provide a small performance optimization by > holding sched_lock for a shorter period of time. Curiously, it actually > resulted in a performance decrease on i386 and amd64 in benchmarks. On a 10 > cpu sparc64 machine it did result in an improvement. I need to do more > research to determine why it would hurt performance for the x86 case (even on > 4 cpu boxes) as I don't want to go committing things that hurt performance. I understand and agree for what that's worth. :) > If I can address the performance problems though this is the interface that > would be presented to userland. OK, I'll keep an eye on this list and /usr/src/UPDATES, assuming it will end up in either if it were added. Meanwhile, I'll see if gkrellm likes my changes sufficiently to commit them to their CVS tree after I got things to work in client/server mode as well. If anything should change for whatever reason it should be fairly trivial to make the necessary changes. Thanks a lot, Marco -- Laat wat je niet laten kunt, en doe wat je niet doen kunt, en word miljonair.