From owner-freebsd-hackers@FreeBSD.ORG  Wed Jun  3 09:03:47 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B8FB106566C
	for <freebsd-hackers@FreeBSD.org>; Wed,  3 Jun 2009 09:03:47 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id EC02C8FC0C
	for <freebsd-hackers@FreeBSD.org>; Wed,  3 Jun 2009 09:03:46 +0000 (UTC)
	(envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id F2A286D41D;
	Wed,  3 Jun 2009 11:03:45 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id CE3E0844C0; Wed,  3 Jun 2009 11:03:45 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: rea-fbsd@codelabs.ru
References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no>
	<20090527233110.E4243@delplex.bde.org> <86r5yaijef.fsf@ds4.des.no>
	<20090529210855.V1643@besplex.bde.org> <86vdnju9z1.fsf@ds4.des.no>
	<86r5y7u9r3.fsf@ds4.des.no>
	<qlE9VS4n+oBC3U4EHMxYsjC7RHI@XX1fo6zQUfC4h0jjRC6IBz3oNH4>
	<86skiiri1p.fsf@ds4.des.no>
	<dl+Tldq1IjLtbwOv9fvp7D68xCc@10Ilc7MfiXA2JVIRVQpZfk7cTQ4>
Date: Wed, 03 Jun 2009 11:03:45 +0200
In-Reply-To: <dl+Tldq1IjLtbwOv9fvp7D68xCc@10Ilc7MfiXA2JVIRVQpZfk7cTQ4> (Eygene
	Ryabinkin's message of "Wed, 3 Jun 2009 00:01:00 +0400")
Message-ID: <86my8pelji.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@FreeBSD.org, Jakub Lach <jakub_lach@mailplus.pl>,
	Bruce Evans <bde@zeta.org.au>
Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file
	symlink) vulnerability
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2009 09:03:47 -0000

Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes:
> "Dag-Erling Sm=C3=B8rgrav" <des@des.no> writes:
> > Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes:
> > > Perhaps 'XXX for direnter()' should be changed to something like
> > > 'strip trailing slashes in cnp->cn_nameptr'.
> > I'll just remove it, since the previous comment clearly explains
> > what is going on.
> May be it's better to leave the comment, but replace it with more
> undestandable one: this instruction is a bit tricky and it makes one to
> think what the hell is going on.

Isn't it clearly described in the preceding comment?  Specifically, by
the first two sentences: "Replace multiple slashes by a single slash and
trailing slashes by a null.  This must be done before VOP_LOOKUP()
because some fs's don't know about trailing slashes."

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no