From owner-freebsd-net@FreeBSD.ORG Wed Nov 21 23:12:34 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F0FC9A6E for ; Wed, 21 Nov 2012 23:12:34 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id AF3318FC14 for ; Wed, 21 Nov 2012 23:12:34 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id 16so9756977obc.13 for ; Wed, 21 Nov 2012 15:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Sfk/jf5VOph62B2ERTl9MLYjezOs92hTBmrMYFicQCE=; b=MD8q/056r+RWwjaM3ONjke2aHXqE0MIEkZop2byL62kAsJ7zqYUuAzlwADmUpkzT4p Y/VJwEpZQMNafdSPO6CdX9NW1ompJhu0w3BA3FKd/x4WVI43S4+jgxhIF46nr44/sKij b6FcQuZtTbzAognmFdQD6CmeYkTk70Y/xtp5CjfKdtvpMB704o31r6qADs33dVs9cAlD Y5fvQy/h6WvcfQ6l0KkEyZA7W8cxJBas5squdEE+YcLNqA83kHgQNfnHn5lN4UX81h7a EJbdi7uvaoOHtD7ncUCv9Aje+HFifOukAviOR0dUFYl6oCd0VbnU0Ed8ZPmHhXZ1ZiV3 wD7A== MIME-Version: 1.0 Received: by 10.182.95.205 with SMTP id dm13mr17914629obb.9.1353539553733; Wed, 21 Nov 2012 15:12:33 -0800 (PST) Received: by 10.76.143.33 with HTTP; Wed, 21 Nov 2012 15:12:33 -0800 (PST) In-Reply-To: References: Date: Wed, 21 Nov 2012 15:12:33 -0800 Message-ID: Subject: Re: [RFC] Prune net.inet6.ip6.rr_prune? From: Garrett Cooper To: Sergey Kandaurov Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2012 23:12:35 -0000 On Wed, Nov 21, 2012 at 3:07 PM, Sergey Kandaurov wrote: > On 21 November 2012 22:39, Garrett Cooper wrote: >> While going through the tree trying to document all of our >> net.inet6 sysctls, I noticed that net.inet6.ip6.rr_prune is defined, >> but not actually used anywhere in the stack: >> >> netinet6/ip6_var.h:VNET_DECLARE(int, ip6_rr_prune); /* router >> renumbering prefix >> netinet6/ip6_var.h:#define V_ip6_rr_prune VNET(ip6_rr_prune) >> netinet6/in6_proto.c:VNET_DEFINE(int, ip6_rr_prune) = 5; /* router >> renumbering prefix >> netinet6/in6_proto.c:SYSCTL_VNET_INT(_net_inet6_ip6, IPV6CTL_RR_PRUNE, >> rr_prune, CTLFLAG_RW, >> netinet6/in6_proto.c: &VNET_NAME(ip6_rr_prune), 0, >> >> The knob was declared in r181803 and shuffled around a few times, >> but isn't in use anywhere (either then or now). >> Should I send out a PR to remove it (or am I missing some context)? > > I believe this knob became unused with invalidation of the prefix > manipulation mechanism (including prefix or router renumbering, rfc2894) > at KAME about 11 years ago. It was intended to schedule in6_rr_timer() > callout every ip6_rr_prune seconds to check for expired prefixes and > delete the associated addresses from interface. > Last bits of old ipv6 prefix management stuff cleaned up in r231229. Interesting. If I don't get any negative feedback, I'll roll it into the patch I was going to submit better documenting the sysctls that I was going to submit via a PR. Thanks! -Garrett