From owner-cvs-src@FreeBSD.ORG Sat Jun 25 03:34:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5108716A41C; Sat, 25 Jun 2005 03:34:50 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3FAAA43D55; Sat, 25 Jun 2005 03:34:50 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j5P3Yoqu011206; Sat, 25 Jun 2005 03:34:50 GMT (envelope-from dd@repoman.freebsd.org) Received: (from dd@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j5P3YoOw011205; Sat, 25 Jun 2005 03:34:50 GMT (envelope-from dd) Message-Id: <200506250334.j5P3YoOw011205@repoman.freebsd.org> From: Dima Dorfman Date: Sat, 25 Jun 2005 03:34:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2005 03:34:50 -0000 dd 2005-06-25 03:34:49 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: Fix fdcheckstd to pass the file descriptor along through vn_open. When opening a device, devfs_open needs the file descriptor to install its own fileops. Failing to pass the file descriptor causes the vnode to be returned with the regular vnops, which will cause a panic on the first read or write because devfs_specops is not meant to support those operations. This bug caused a panic after exec'ing any set[ug]id program with fds 0..2 closed (i.e., if any action had to be taken by fdcheckstd, we would panic if the exec'd program ever tried to use any of those descriptors). Reviewed by: phk Approved by: re (scottl) Revision Changes Path 1.279 +1 -1 src/sys/kern/kern_descrip.c