From owner-freebsd-bugs@freebsd.org  Tue Aug  8 15:56:02 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D892FDBFDE8
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  8 Aug 2017 15:56:02 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C5C0C67888
 for <freebsd-bugs@FreeBSD.org>; Tue,  8 Aug 2017 15:56:02 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v78Fu2eC026064
 for <freebsd-bugs@FreeBSD.org>; Tue, 8 Aug 2017 15:56:02 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 217747] sys/dev/mly/mly.c: PVS-Studio: NULL Pointer Dereference
 (CWE-476) (1)
Date: Tue, 08 Aug 2017 15:56:02 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: jhb@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-217747-8-WXDL3iDCeS@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217747-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-217747-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Aug 2017 15:56:03 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217747

--- Comment #1 from John Baldwin <jhb@FreeBSD.org> ---
Created attachment 185158
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185158&action=
=3Dedit
mly.patch

I would probably either move the check of mc_data into the 'if (mc !=3D NUL=
L)'
block, or do the approach above where we just return immediately if we fail=
 to
get a command and then 'mc' is never NULL when 'out' is jumped to.

--=20
You are receiving this mail because:
You are the assignee for the bug.=