From owner-svn-src-all@freebsd.org Fri Jan 29 23:48:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C616A711B7 for ; Fri, 29 Jan 2016 23:48:02 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9522F1FE5 for ; Fri, 29 Jan 2016 23:48:01 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f49.google.com with SMTP id 78so18149118lfy.3 for ; Fri, 29 Jan 2016 15:48:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=y559P3JjmaUb9D1w2XgxnUlMWQAjNt/Vnm7FrU83eiI=; b=CcOdSDrxi9t7adB0Ev5ytuMy5pXoDQC6IfMXpps/r2EUrYJpv6W+FMIUfQn8csvP6c 0Rn0O7HW2WOhv1z/F1UiGQ1AyIiFYpY5iJsJy5baTe/ikLahg3NAP79s1FhAfkA3fZbL Kmig+UP2zr5vbf5UOdNeXklWybsFe5lgP28ZgNSkab081rewxnC+GiUxWIWyw5DoMQIv iWaEWX0uD16viOw7ZHY3ZFSy8jyJCDij10y2isKEIC6UTGKKB31zfEi2rhZ0ERRrHmiq MMhLHCsZ5kIclrt8851Og5JjaKvbUDiszLJrtKRcR3XzF1W3NfArLO5i0Uft4Hk2Jigh iiSw== X-Gm-Message-State: AG10YOR1R41lEZipksAaJkjr3zogg+UgBDAvhWBqLS9WEsQRjrkRuxS5KLFT37tKtgj6vA== X-Received: by 10.25.207.3 with SMTP id f3mr4432494lfg.20.1454111273485; Fri, 29 Jan 2016 15:47:53 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id n185sm2321795lfd.27.2016.01.29.15.47.52 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jan 2016 15:47:53 -0800 (PST) Subject: Re: svn commit: r294981 - in stable/10/sys/boot: common efi efi/boot1 efi/include efi/libefi efi/loader efi/loader/arch/amd64 fdt i386/libi386 To: Steven Hartland , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org References: <201601281211.u0SCBhQG058154@repo.freebsd.org> <56ABF762.7010103@freebsd.org> From: Andrey Chernov Message-ID: <56ABFA28.1000207@freebsd.org> Date: Sat, 30 Jan 2016 02:47:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56ABF762.7010103@freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 23:48:02 -0000 On 30.01.2016 2:36, Andrey Chernov wrote: > I am not sure this is exact commit which cause this, but any operation > in /sys/boot/efi ends like this (by hand, not from buildworld): > (i386-stable machine, clang compiler) > > ===> efi (obj) > make[1]: "/usr/src/sys/boot/efi/Makefile" line 4: Malformed conditional > (${COMPILER_TYPE} != "gcc") > make[1]: Fatal errors encountered -- cannot continue > make[1]: stopped in /usr/src/sys/boot/efi > *** Error code 1 > > Stop. > make: stopped in /usr/src/sys/boot > As Makefile shows, there is no include to pick COMPILER_TYPE and it is undefined. You need at least to move bsd.subdir.mk up. # $FreeBSD: stable/10/sys/boot/efi/Makefile 294981 2016-01-28 12:11:42Z smh $ # In-tree GCC does not support __attribute__((ms_abi)). .if ${COMPILER_TYPE} != "gcc" .if ${MACHINE_CPUARCH} == "amd64" SUBDIR+= libefi loader boot1 .endif .endif # ${COMPILER_TYPE} != "gcc" .include -- http://ache.vniz.net/