From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 27 15:10:14 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09CA116A4CE for ; Mon, 27 Dec 2004 15:10:14 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFA6F43D48 for ; Mon, 27 Dec 2004 15:10:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBRFADYT067076 for ; Mon, 27 Dec 2004 15:10:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBRFADDB067075; Mon, 27 Dec 2004 15:10:13 GMT (envelope-from gnats) Resent-Date: Mon, 27 Dec 2004 15:10:13 GMT Resent-Message-Id: <200412271510.iBRFADDB067075@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sergiy Vyshnevetskiy Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 662D716A4CE for ; Mon, 27 Dec 2004 15:01:39 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 303DB43D5A for ; Mon, 27 Dec 2004 15:01:39 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBRF1d1v073801 for ; Mon, 27 Dec 2004 15:01:39 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iBRF1c41073800; Mon, 27 Dec 2004 15:01:38 GMT (envelope-from nobody) Message-Id: <200412271501.iBRF1c41073800@www.freebsd.org> Date: Mon, 27 Dec 2004 15:01:38 GMT From: Sergiy Vyshnevetskiy To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/75542: Inconsistent naming of a tunable and weird code in sysvshm module X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2004 15:10:14 -0000 >Number: 75542 >Category: kern >Synopsis: Inconsistent naming of a tunable and weird code in sysvshm module >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Dec 27 15:10:13 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Sergiy Vyshnevetskiy >Release: 5-stable >Organization: >Environment: FreeBSD serg.vostok.net 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Dec 6 11:01:12 EET 2004 root@serg.vostok.net:/usr/5/src/sys/i386/compile/SERG i386 >Description: kern.ipc.shmmaxpgs tunable is accessible as kern.ipc.shmall with sysctl. Meaningless code near it's definition. >How-To-Repeat: Remove options SYSVSHM from your kernel configuration file. Recompile kernel and reboot. Load sysvshm module. You will have to use kern.ipc.shmmaxpgs tunable but will see it as kern.ipc.shmall in sysctl output. >Fix: --- sys/kern/sysv_shm.c.orig Fri Dec 3 17:02:20 2004 +++ sys/kern/sysv_shm.c Fri Dec 3 17:04:58 2004 @@ -863,12 +863,8 @@ { int i; - TUNABLE_INT_FETCH("kern.ipc.shmmaxpgs", &shminfo.shmall); - for (i = PAGE_SIZE; i > 0; i--) { - shminfo.shmmax = shminfo.shmall * PAGE_SIZE; - if (shminfo.shmmax >= shminfo.shmall) - break; - } + TUNABLE_INT_FETCH("kern.ipc.shmall", &shminfo.shmall); + shminfo.shmmax = shminfo.shmall * PAGE_SIZE; TUNABLE_INT_FETCH("kern.ipc.shmmin", &shminfo.shmmin); TUNABLE_INT_FETCH("kern.ipc.shmmni", &shminfo.shmmni); TUNABLE_INT_FETCH("kern.ipc.shmseg", &shminfo.shmseg); >Release-Note: >Audit-Trail: >Unformatted: