From owner-svn-src-all@FreeBSD.ORG Sun Oct 28 21:03:40 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BA8A4A09 for ; Sun, 28 Oct 2012 21:03:40 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 1D6EC8FC19 for ; Sun, 28 Oct 2012 21:03:39 +0000 (UTC) Received: (qmail 92770 invoked from network); 28 Oct 2012 22:40:36 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 28 Oct 2012 22:40:36 -0000 Message-ID: <508D9DA4.2000401@freebsd.org> Date: Sun, 28 Oct 2012 22:03:32 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r242254 - head/sys/netinet References: <201210281807.q9SI7Yxa069395@svn.freebsd.org> <20121028200700.GL70741@FreeBSD.org> In-Reply-To: <20121028200700.GL70741@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 21:03:40 -0000 On 28.10.2012 21:07, Gleb Smirnoff wrote: > On Sun, Oct 28, 2012 at 06:07:34PM +0000, Andre Oppermann wrote: > A> @@ -296,8 +297,8 @@ syncache_destroy(void) > A> mtx_destroy(&sch->sch_mtx); > A> } > A> > A> - KASSERT(V_tcp_syncache.cache_count == 0, ("%s: cache_count %d not 0", > A> - __func__, V_tcp_syncache.cache_count)); > A> + KASSERT(uma_zone_get_cur(V_tcp_syncache.zone) == 0, > A> + ("%s: cache_count not 0", __func__)); > A> > A> /* Free the allocated global resources. */ > A> uma_zdestroy(V_tcp_syncache.zone); > > btw, keg_dtor() which is called in uma_zdestroy() printfs a warning > (even on non-invariant kernel) if keg had items in it. So leak won't > be unnoticed. Thanks, didn't know that. I leave the KASSERT() in if you don't mind to make it a bit more forceful than a printf that gets overlooked too easily. -- Andre