From owner-freebsd-stable@FreeBSD.ORG Tue Apr 22 23:26:21 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2292106567B for ; Tue, 22 Apr 2008 23:26:21 +0000 (UTC) (envelope-from andrew@modulus.org) Received: from email.octopus.com.au (host-122-100-2-232.octopus.com.au [122.100.2.232]) by mx1.freebsd.org (Postfix) with ESMTP id 917738FC1F for ; Tue, 22 Apr 2008 23:26:21 +0000 (UTC) (envelope-from andrew@modulus.org) Received: by email.octopus.com.au (Postfix, from userid 1002) id 4B9E613F8D; Wed, 23 Apr 2008 09:26:19 +1000 (EST) X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on email.octopus.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=10.0 tests=ALL_TRUSTED autolearn=failed version=3.2.3 Received: from [10.20.30.101] (60.218.233.220.exetel.com.au [220.233.218.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: admin@email.octopus.com.au) by email.octopus.com.au (Postfix) with ESMTP id 099181392A; Wed, 23 Apr 2008 09:26:14 +1000 (EST) Message-ID: <480E7412.2040802@modulus.org> Date: Wed, 23 Apr 2008 09:26:10 +1000 From: Andrew Snow User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Zaphod Beeblebrox References: <480D7F58.1080203@modulus.org> <5f67a8c40804221136s2c1893c0tdd00c627ab813c59@mail.gmail.com> In-Reply-To: <5f67a8c40804221136s2c1893c0tdd00c627ab813c59@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-stable@freebsd.org, Pete French Subject: Re: Dreadful gmirror performance, though each half works fine X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Apr 2008 23:26:21 -0000 Zaphod Beeblebrox wrote: > I use this patch for sbin/geom/class/mirror/geom_mirror.c > > Change: > md.md_priority = i - 1; > To: > md.md_priority = i - 1 + 100; > > > I hate to ask for the "right" solution, but shouldn't we be patching > the gmirror userland to accept a priority argument to label and make the > kernel part listen to that? This patch does make sense --- but it > doesn't go far enough. > > Also, it seems sensible that you should be able to modify the priority > values of a running disk. Both of those are good ideas. But for years, no one can be bothered making a patch. At least my patch is only one line, and solves 90% of the problem, and still no one can be bothered committing it. Maybe we should apply my patch for now, until someone works on the rest. - Andrew