From owner-freebsd-doc Sat Jun 16 23:43: 2 2001 Delivered-To: freebsd-doc@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 1E67237B405 for ; Sat, 16 Jun 2001 23:42:31 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 7EA743E28; Sat, 16 Jun 2001 23:42:26 -0700 (PDT) To: Warner Losh Cc: doc@freebsd.org Subject: Re: Updates to committer's guide for getting commit bits. In-Reply-To: <200106170542.f5H5gsV44690@harmony.village.org>; from imp@harmony.village.org on "Sat, 16 Jun 2001 23:42:54 -0600" Date: Sat, 16 Jun 2001 23:42:26 -0700 From: Dima Dorfman Message-Id: <20010617064226.7EA743E28@bazooka.unixfreak.org> Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Comments below. Warner Losh writes: > Index: article.sgml > =================================================================== > RCS file: /home/imp/FreeBSD/CVS/doc/en_US.ISO8859-1/articles/committers-guide > /article.sgml,v > retrieving revision 1.72 > diff -u -r1.72 article.sgml > --- article.sgml 2001/06/11 01:16:39 1.72 > +++ article.sgml 2001/06/17 05:39:06 > @@ -60,7 +60,8 @@ > > Main CVS Repository Meisters > &a.jdp; and &a.peter; as well as &a.asami; for > - ports/ > + ports/ and &a.nik; for > + doc/ > > > > @@ -674,6 +675,13 @@ > review your diffs, using > cvs diff > > + > + > + if the software has a MAINTAINER, or someone else has made ^^^ Capital? > + a number of commits to the file more than anyone else, make > + sure you have tried to have that person review your changes > + before the commit. > + > > > Also, ALWAYS specify which files to commit explicitly on > @@ -834,7 +842,8 @@ > > > All new committers also have a mentor assigned to them for > - the first few months. Your mentor is more or less responsible for > + the first few months. Your mentor sponsored your commit bit with > + core. Your mentor is more or less responsible for I think this should be: Your mentor sponsored your commit bit with the &a.core;. > explaining anything which is confusing to you and is also > responsible for your actions during this initial period. If you > make a bogus commit, it is only going to embarrass your mentor > @@ -1675,7 +1684,8 @@ > yourself! > > Contact the &a.core; if you wish to take up maintainership > - of an unmaintained part of the tree. > + of an unmaintained part of the tree or if you have issues with > + the maintainer of part of the tree. > > > > @@ -2257,4 +2267,54 @@ > > > > + > + > + From time to time, committers will come across new, and promising > + people who would be able to make valuable contributions to the FreeBSD > + project. Maybe they have posted a lot of patches. Maybe they have > + submitted too many PRs for them to escape punishment. Maybe they > + write well and can contribute to the documentation effort. Maybe they > + wish to attack the ports tree. In any event, when one finds a qualified > + new committer, one must follow a procedure to get this person's > + commit bit. > + > + If the commit bit is for src, send your request (and justification) > + to core@FreeBSD.org. If the commit bit is for ports, "... to the &a.core;." > + send your request to &a.asami;. If the commit bit is for doc, send > + your request to &a.nik;. The mentor for this new person should make > + the request. You should get an ack of your request s/ack/acknowledgement/, please. > + back within 24 hours. You should get resolution of your request, > + one way or another within one week. If you fail to get these things I don't know if the 24 hour thing is reasonable for Nik or Asami. Core is a team, but they're one person, and it isn't unusual for one of them to be gone for a day or two. > + in a timely fashion, then write to core. &a.core; > + > + If the request is refused, a letter explaining the refusal will > + be sent to the sponsor in the case of src commit bits. Other tree > + may also do the same. Often times the answer of "not yet" will be > + sent out. Mentors are encouraged to work with their applicant in such > + a case and resubmit their request, if appropriate after a few months > + when the concerns raised in the refusal letter have been > + addressed. > + > + If the request is granted, then the authorizing body listed above > + needs to send a pgp signed message to admin@FreeBSD.org authorizing "... to admin@FreeBSD.org ..." > + creation of the account. Once that is done, the admin folks will request > + information about the applicant for use in creating their account and > + giving them credentials to log in. The mentor is expected to followup > + with the new committer and make sure that he or she reads this document > + and follows the first initial steps listed here. > + > + If you are a doc committer, you can commit to both the src > + and doc trees. But only to documentation in the src tree. > + Otherwise, you should get approval from the issuing authority > + to start making commits outside of the area for which you > + were originally approved. > + > + Any problems in this process should be reported to the authorizing > + authority first, and then to core if they cannot be resolved. Each step &a.core; > + without a time limit explicitly listed should be considered to have a > + 48 hour timeout on it and the mentor is responsible for following up > + appropriately. This is a volunteer organization and sometimes action > + items fall onto the floor and the mentor is our oversight in this > + process. > + > Other than those minor nits, I think it's a good idea. If you'd like, I'll gladly commit it for you when you're ready. Regards, Dima Dorfman dima@unixfreak.org P.S. Sorry if I sounded too bde-ish ;-). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message