From owner-freebsd-ports@FreeBSD.ORG Thu Mar 10 11:05:41 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6889616A4CE for ; Thu, 10 Mar 2005 11:05:41 +0000 (GMT) Received: from ares.wolfpond.org (ns1.wolfpond.org [62.212.96.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB2F343D1F for ; Thu, 10 Mar 2005 11:05:39 +0000 (GMT) (envelope-from ftigeot@wolfpond.org) Received: from aoi.wolfpond.org (aoi.wolfpond.org [IPv6:2001:7a8:24db:1:20c:76ff:feb4:27e1]) by ares.wolfpond.org (8.13.3/8.13.3) with ESMTP id j2AB5c0j029816; Thu, 10 Mar 2005 12:05:38 +0100 (CET) (envelope-from ftigeot@aoi.wolfpond.org) Received: from aoi.wolfpond.org (localhost [127.0.0.1]) by aoi.wolfpond.org (8.13.3/8.13.1) with ESMTP id j2AB5bSq000961; Thu, 10 Mar 2005 12:05:37 +0100 (CET) (envelope-from ftigeot@aoi.wolfpond.org) Received: (from ftigeot@localhost) by aoi.wolfpond.org (8.13.3/8.13.1/Submit) id j2AB5ard000960; Thu, 10 Mar 2005 12:05:36 +0100 (CET) (envelope-from ftigeot) Date: Thu, 10 Mar 2005 12:05:36 +0100 From: Francois Tigeot To: Scot Hetzel Message-ID: <20050310110536.GA822@aoi.wolfpond.org> References: <20050308085234.GA22654@aoi.wolfpond.org> <790a9fff05030909047e24089c@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <790a9fff05030909047e24089c@mail.gmail.com> User-Agent: Mutt/1.4.2.1i cc: freebsd-ports@freebsd.org Subject: Re: x11/xlockmore disables MESAGL on amd64 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2005 11:05:41 -0000 On Wed, Mar 09, 2005 at 11:04:26AM -0600, Scot Hetzel wrote: > On Tue, 8 Mar 2005 09:52:34 +0100, Francois Tigeot wrote: > > GL modes have been disabled on amd64 more than a year ago. According to the > > commit message, it was done to fix build problems. > > > > I re-enabled them locally; xlockmore built without trouble and all GL modes > > work fine on a 5.4-PRERELEASE/amd64 host. > > > > Should I submit a PR or is the attached patch sufficient ? > > > I looked at the patch and it removes the check for amd64. The check > should have been changed to include OSVERSION, as the GL modes are > broken on older versions. > > .if ${MACHINE_ARCH} == "amd64" && ${OSVERSION} < 503105 > WITH_MESAGL= no > .else > WITH_MESAGL?= yes > .endif > > Also, if you can test on a 5.3-RELEASE system, you could bring the > OSVERSION down even further. With 5.2-RELEASE, the build fails. The compiler generates an invalid assembler sequence on this version. The port compiles correctly on a 5.3-BETA7 system, so 5.3-RELEASE should be fine. The exact OSVERSION could probably be changed to 502126, when gcc was upgraded to 3.4.x. -- Francois Tigeot