Date: Fri, 30 Oct 2020 16:20:11 +0100 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: =?UTF-8?Q?Stefan_E=c3=9fer?= <se@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r553696 - in head/deskutils/calendar: . files Message-ID: <0b98dc4d-e1f5-4cd1-1229-74aeb650b886@FreeBSD.org> In-Reply-To: <202010301501.09UF15fR092744@repo.freebsd.org> References: <202010301501.09UF15fR092744@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Stefan, Thanks for all the focus on the calendar! I just wonder if patch-* files are the best place for those updates. Shouldn't those patches be applied to the repo where calendar now lives instead? Then we could just bump the port version in the ports tree. Especially that the current upstream for calendar seems to be bsdimp's GitHub repo. On 10/30/20 4:01 PM, Stefan Eßer wrote: > Author: se > Date: Fri Oct 30 15:01:04 2020 > New Revision: 553696 > URL: https://svnweb.freebsd.org/changeset/ports/553696 > > Log: > Update to FreeBSD SVN revision r367167 > > This update implements comment handling lost when calendar was changed > from using an external cpp to an internal pre-processor > > Deleted: > head/deskutils/calendar/files/patch-calendar.h > Modified: > head/deskutils/calendar/Makefile > head/deskutils/calendar/distinfo > head/deskutils/calendar/files/patch-io.c > head/deskutils/calendar/files/patch-pathnames.h > > Modified: head/deskutils/calendar/Makefile > ============================================================================== > --- head/deskutils/calendar/Makefile Fri Oct 30 14:59:03 2020 (r553695) > +++ head/deskutils/calendar/Makefile Fri Oct 30 15:01:04 2020 (r553696) > @@ -1,7 +1,7 @@ > # $FreeBSD$ > > PORTNAME= calendar > -DISTVERSION= 0.3 > +DISTVERSION= 0.5 > CATEGORIES= deskutils > > MAINTAINER= se@FreeBSD.org > @@ -15,7 +15,7 @@ USE_GITHUB= yes > GH_ACCOUNT= bsdimp > GH_TAGNAME= fcc5d31 > > -CFLAGS+= -DLOCALBASE=${LOCALBASE} > +CFLAGS+= -D_PATH_LOCALBASE=\"${LOCALBASE}\" -g -O0 # -DDEBUG I understand that this port is in active development (which should probably happen outside of the head of the ports tree) but this setting does not respect CFLAGS set by the user. Cheers! Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0b98dc4d-e1f5-4cd1-1229-74aeb650b886>