From owner-freebsd-arch@FreeBSD.ORG  Mon Feb 11 21:20:02 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 264D8CA2;
 Mon, 11 Feb 2013 21:20:02 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-we0-x22c.google.com (mail-we0-x22c.google.com
 [IPv6:2a00:1450:400c:c03::22c])
 by mx1.freebsd.org (Postfix) with ESMTP id 726D2EDB;
 Mon, 11 Feb 2013 21:20:01 +0000 (UTC)
Received: by mail-we0-f172.google.com with SMTP id x10so5331575wey.3
 for <multiple recipients>; Mon, 11 Feb 2013 13:20:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=S5opBg+X2FXm6wLdS0+cded06RCC9N5JJ2QjwsEHs+4=;
 b=JEGWsFaccDrQTIG3i+qOri3u7K1M3fbWQm2jjZ46z/T1/JdjYymrXyj4LYUoJPKjUd
 z4TZ9X9Qqs+ym3crxkBFyMy9V7YWx/+ktpLcAm447E9Lam9i+u6v4rvrXuOC5JE+L9lL
 FJyOh4jkXQogH/HFNovraDyg0p8D6aQGwzFP1Xks31Vhy3KAlA9Wr3KBBEmKSGUCXaQU
 kLJWJaGYq2RoeZI46JrOoaIdmWXXdNvEqmkHJwRdhkP9P6XLXCJL1tzvDF4wYDGPfdgW
 JfXgL3uQ2f+W0NTvg1ynCeRcgVCf8qSW5sW/km36ge47rZrVAAU84FETLs/3uIFeqSUO
 FBFQ==
MIME-Version: 1.0
X-Received: by 10.181.12.103 with SMTP id ep7mr18561029wid.12.1360617600614;
 Mon, 11 Feb 2013 13:20:00 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.216.236.88 with HTTP; Mon, 11 Feb 2013 13:20:00 -0800 (PST)
In-Reply-To: <201302111203.19422.jhb@freebsd.org>
References: <51141E33.4080103@gmx.de> <201302111105.58186.jhb@freebsd.org>
 <51191EC1.9000303@gmx.de> <201302111203.19422.jhb@freebsd.org>
Date: Mon, 11 Feb 2013 13:20:00 -0800
X-Google-Sender-Auth: XPYbVAyqHtXGhOcwlNj-V62T1Qg
Message-ID: <CAJ-Vmokt+yq7WMpW0S5Kzy7y1EFGU6g6pHt=QuoZ-zs+G-U0BQ@mail.gmail.com>
Subject: Re: Proposal: Unify printing the function name in panic messages()
From: Adrian Chadd <adrian@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Kirk McKusick <mckusick@mckusick.com>,
 Christoph Mallon <christoph.mallon@gmx.de>, Andriy Gapon <avg@freebsd.org>,
 freebsd-arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2013 21:20:02 -0000

Whoa, whoa.

Are you seriously trying to argue that having a consistent file:line
isn't a really helpful addition to panic messages?

Yes, you can get it via the crash IP and use of binutils on the kernel
image. But with modules? You have to fire up kgdb, and that requires a
dump _and_ a kgdb that matches the kernel image in question.

Even if you don't add it to the panic message, having that information
passed into panic() so it can print out a file:line would be great.



Adrian