From owner-freebsd-usb@FreeBSD.ORG  Sat Feb  3 16:20:27 2007
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
X-Original-To: freebsd-usb@hub.freebsd.org
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3AB7116A401
	for <freebsd-usb@hub.freebsd.org>; Sat,  3 Feb 2007 16:20:27 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id D9A9613C481
	for <freebsd-usb@hub.freebsd.org>; Sat,  3 Feb 2007 16:20:26 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l13GKQBw032547
	for <freebsd-usb@freefall.freebsd.org>; Sat, 3 Feb 2007 16:20:26 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l13GKQMB032546;
	Sat, 3 Feb 2007 16:20:26 GMT (envelope-from gnats)
Date: Sat, 3 Feb 2007 16:20:26 GMT
Message-Id: <200702031620.l13GKQMB032546@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: usb/108719: commit references a PR
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Feb 2007 16:20:27 -0000

The following reply was made to PR usb/108719; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: usb/108719: commit references a PR
Date: Sat,  3 Feb 2007 16:19:45 +0000 (UTC)

 imp         2007-02-03 16:19:28 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/usb          uhub.c 
   Log:
   Fix memory leak of devinfo.  The leak itself was documented in
   PR/108719, but there's a simpler fix: free it after it is used, and
   then get rid of the redundant frees this causes.  Other leaks in this
   PR not yet fixed.
   
   While I'm here, remove NetBSD/OpenBSD code and some of the portability
   #defines that were getting in the way of understanding this code.  The
   devinfo bug was harder to spot because one needed to know that
   device_set_desc_copy() was used inside of one of them (one that didn't
   take an argument!).
   
   Prefer device_printf(sc->sc_dev, "...") to printf("%s:...",
   device_get_nameunit(sc->sc_dev)).  This saves almost 300 bytes.
   
   PR: 108719
   Submitted by: Antoine Brodin
   
   Revision  Changes    Path
   1.73      +66 -122   src/sys/dev/usb/uhub.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"