From owner-freebsd-audit Mon May 21 0:25:15 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mailc.telia.com (mailc.telia.com [194.22.190.4]) by hub.freebsd.org (Postfix) with ESMTP id 59D6037B42C for ; Mon, 21 May 2001 00:25:11 -0700 (PDT) (envelope-from watchman@ludd.luth.se) Received: from d1o907.telia.com (d1o907.telia.com [195.252.38.241]) by mailc.telia.com (8.11.2/8.11.0) with ESMTP id f4L7P9L15372; Mon, 21 May 2001 09:25:09 +0200 (CEST) Received: from ludd.luth.se (h55n1fls21o907.telia.com [212.181.140.55]) by d1o907.telia.com (8.8.8/8.8.8) with ESMTP id JAA12713; Mon, 21 May 2001 09:25:08 +0200 (CEST) Message-ID: <3B08C2CB.2ABF2EF2@ludd.luth.se> Date: Mon, 21 May 2001 09:24:59 +0200 From: Joachim =?iso-8859-1?Q?Str=F6mbergson?= Organization: Acne X-Mailer: Mozilla 4.76 [en] (X11; U; FreeBSD 4.3-STABLE i386) X-Accept-Language: en-US MIME-Version: 1.0 To: Mike Heffner Cc: FreeBSD-Audit Subject: Re: Patch to add nic-se to whois References: Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Aloha! Mike Heffner wrote: > Except for breaking style(9) (spaces instead of tabs), it looks alright. Also, > don't forget to update whois.1. Ok, fixed. Thanks! Next stop will be the man page. When talking about style here, I tried to insert the addition in alphabetical order. Looking at the source for whois, some of the defines for the other databases seems to have been added without taking care of this: #define NICHOST "whois.crsnic.net" #define INICHOST "whois.networksolutions.com" #define DNICHOST "whois.nic.mil" #define GNICHOST "whois.nic.gov" #define ANICHOST "whois.arin.net" #define RNICHOST "whois.ripe.net" #define PNICHOST "whois.apnic.net" #define RUNICHOST "whois.ripn.net" #define MNICHOST "whois.ra.net" #define QNICHOST_TAIL ".whois-servers.net" #define SENICHOST "whois.nic-se.se" #define SNICHOST "whois.6bone.net" Is this important and/or something we want? I checked man style(9) and it seems to recommend sorting rules for includes and variables. I could sort these if that would seem appropriate while I'm at it. > | this something we should add to the system? > > Sure. Does this option, `s', conflict with any of the other BSDs? Well the OpenBSD patch used 's' for this option. Dunno about NetBSD and BSDi. I'll check. -- Med vänlig hälsning, Cheers! Joachim Strömbergson ============================================================================ Joachim Strömbergson - ASIC designer, nice to *cute* animals. snail: phone: mail & web: Sävenäsgatan 5A +46 31 - 27 98 47 watchman@ludd.luth.se 416 72 Göteborg +46 733 75 97 02 www.ludd.luth.se/~watchman ============================================================================ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message