From owner-freebsd-ports@FreeBSD.ORG Sun Oct 3 11:10:38 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4B1B106564A for ; Sun, 3 Oct 2010 11:10:38 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) by mx1.freebsd.org (Postfix) with ESMTP id 585CF8FC1D for ; Sun, 3 Oct 2010 11:10:37 +0000 (UTC) Received: from elsa.codelab.cz (localhost.codelab.cz [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id B488F19E02E; Sun, 3 Oct 2010 12:54:29 +0200 (CEST) Received: from [192.168.1.2] (ip-86-49-61-235.net.upcbroadband.cz [86.49.61.235]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 495BE19E02A; Sun, 3 Oct 2010 12:54:27 +0200 (CEST) Message-ID: <4CA860E2.2080402@quip.cz> Date: Sun, 03 Oct 2010 12:54:26 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.13) Gecko/20100914 SeaMonkey/2.0.8 MIME-Version: 1.0 To: Dominic Fandrey References: <4C93AA31.5080202@DataIX.net> <20100918223933.GB85995@dragon.NUXI.org> <20101002002605.GA8018@dragon.NUXI.org> <4CA844E5.7060303@infracaninophile.co.uk> <4CA85617.7060503@bsdforen.de> In-Reply-To: <4CA85617.7060503@bsdforen.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David DEMELIER , FreeBSD Ports Subject: Re: OPTIONS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Oct 2010 11:10:38 -0000 Dominic Fandrey wrote: > On 03/10/2010 11:45, David DEMELIER wrote: >> 2010/10/3 Matthew Seaman: >> I don't want something complex, checkbox, textbox, radiobuttons is enough. > > Textbox is _very_ complex. Think of all the code you'd have to > add to ports to check what was entered by the user. > At the very least you have to verify that whatever was provided > is valid. For the feature not to become annoying you'd have to > be a lot more fuzzy and complex, though. You don't need to. It is the same as if user put something wrong in to make.conf, ports.conf or even if somebody do: cd /usr/ports/databases/mysql51-server make WITH_CHARSET=UTF13 WITH_XCHARSET=1 WITH_COLLATION=true All of them are invalid and not checked by ports framework, so if somebody implements textbox in to OPTIONS framework, the situation will not be worse! Situation will be better for those users not familiar with WITH_XXXX knobs. Miroslav Lachman