From owner-cvs-all@FreeBSD.ORG Mon Nov 29 04:54:19 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B6BA16A4CE; Mon, 29 Nov 2004 04:54:19 +0000 (GMT) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4B9543D39; Mon, 29 Nov 2004 04:54:18 +0000 (GMT) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id B295472DF9; Sun, 28 Nov 2004 20:54:18 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id B01AD72DF8; Sun, 28 Nov 2004 20:54:18 -0800 (PST) Date: Sun, 28 Nov 2004 20:54:18 -0800 (PST) From: Doug White To: Colin Percival In-Reply-To: <200411281916.iASJG0RS029275@repoman.freebsd.org> Message-ID: <20041128205113.W40277@carver.gumbysoft.com> References: <200411281916.iASJG0RS029275@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_export.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2004 04:54:19 -0000 On Sun, 28 Nov 2004, Colin Percival wrote: > cperciva 2004-11-28 19:16:00 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_export.c > Log: > Check that saddr->sa_family is a sensible value before using it. > > Reported by: Bryan Fulton and Ted Unangst, Coverity, Inc. > Found by: The SWAT analysis tool This does not compile (on sparc64 at least): cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/a/src/sys -I/a/src/sys/contrib/dev/acpica -I/a/src/sys/contrib/altq -I/a/src/sys/contrib/ipfilter -I/a/src/sys/contrib/pf -I/a/src/sys/contrib/dev/ath -I/a/src/sys/contrib/dev/ath/freebsd -I/a/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -mcmodel=medlow -msoft-float -ffreestanding -Werror /a/src/sys/kern/vfs_export.c /a/src/sys/kern/vfs_export.c: In function `vfs_hang_addrlist': /a/src/sys/kern/vfs_export.c:132: error: `SA_MAX' undeclared (first use in this function) /a/src/sys/kern/vfs_export.c:132: error: (Each undeclared identifier is reported only once /a/src/sys/kern/vfs_export.c:132: error: for each function it appears in.) I can't find a reference to an SA_MAX constant. Did you mean AF_MAX? -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org